Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-135468: Improve BaseHandler.http_error_default() parameter descriptions #136797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 19, 2025

Conversation

valeriogianella
Copy link
Contributor

@valeriogianella valeriogianella commented Jul 19, 2025

@python-cla-bot
Copy link

python-cla-bot bot commented Jul 19, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

@valeriogianella
Copy link
Contributor Author

@AA-Turner Thanks for the help and the review.

Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could possibly use :param: here in the future, but this is an improvement.

A

@AA-Turner AA-Turner added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes sprint labels Jul 19, 2025
@AA-Turner AA-Turner merged commit 57acd65 into python:main Jul 19, 2025
26 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Jul 19, 2025
@miss-islington-app
Copy link

Thanks @valeriogianella for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@AA-Turner AA-Turner changed the title gh-135468: urllib.request.HTTPRedirectHandler documentation uses hdrs instead of headers gh-135468: Improve BaseHandler.http_error_default() parameter descriptions Jul 19, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 19, 2025
…er descriptions (pythonGH-136797)

(cherry picked from commit 57acd65a30f8cb1f3a3cc01322f03215017f5caa)

Co-authored-by: Valerio Gianella <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 19, 2025
…er descriptions (pythonGH-136797)

(cherry picked from commit 57acd65)

Co-authored-by: Valerio Gianella <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jul 19, 2025

GH-136825 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jul 19, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jul 19, 2025

GH-136826 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news sprint
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants