From cf0436d91109bafc86fade223ef0a9b78b12bf66 Mon Sep 17 00:00:00 2001 From: Vladimir Date: Wed, 28 Oct 2020 00:55:44 -0700 Subject: [PATCH 1/5] Fix bpo-38413 Remove outdate note about multithreading in sqlite3 --- Doc/library/sqlite3.rst | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/Doc/library/sqlite3.rst b/Doc/library/sqlite3.rst index 13aa8c512d0319..25a41033a0fbc5 100644 --- a/Doc/library/sqlite3.rst +++ b/Doc/library/sqlite3.rst @@ -1087,19 +1087,6 @@ committed: .. literalinclude:: ../includes/sqlite3/ctx_manager.py -Common issues -------------- - -Multithreading -^^^^^^^^^^^^^^ - -Older SQLite versions had issues with sharing connections between threads. -That's why the Python module disallows sharing connections and cursors between -threads. If you still try to do so, you will get an exception at runtime. - -The only exception is calling the :meth:`~Connection.interrupt` method, which -only makes sense to call from a different thread. - .. rubric:: Footnotes .. [#f1] The sqlite3 module is not built with loadable extension support by From cb2345994a1c22897b715dc744f3eb32d7bac869 Mon Sep 17 00:00:00 2001 From: Vladimir Date: Wed, 4 Nov 2020 17:56:21 -0800 Subject: [PATCH 2/5] Update sqlite3.rst Improve wording and formatting in the footnote. --- Doc/library/sqlite3.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Doc/library/sqlite3.rst b/Doc/library/sqlite3.rst index 25a41033a0fbc5..64919399b7aad9 100644 --- a/Doc/library/sqlite3.rst +++ b/Doc/library/sqlite3.rst @@ -1091,6 +1091,6 @@ committed: .. [#f1] The sqlite3 module is not built with loadable extension support by default, because some platforms (notably Mac OS X) have SQLite - libraries which are compiled without this feature. To get loadable - extension support, you must pass --enable-loadable-sqlite-extensions to - configure. + libraries which are compiled without this feature. To get loadable extension + support, your Python must be compiled with + ``-–enable-loadable-sqlite-extensions`` option in ``PYTHON_CONFIGURE_OPTS``. From ced42cd8ed05e598f631634996c453119e727319 Mon Sep 17 00:00:00 2001 From: Vladimir Date: Tue, 5 Jan 2021 09:00:40 -0800 Subject: [PATCH 3/5] Update sqlite3.rst Revert to mentioning "configure" script. --- Doc/library/sqlite3.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Doc/library/sqlite3.rst b/Doc/library/sqlite3.rst index 64919399b7aad9..b990d3b474b332 100644 --- a/Doc/library/sqlite3.rst +++ b/Doc/library/sqlite3.rst @@ -1093,4 +1093,5 @@ committed: default, because some platforms (notably Mac OS X) have SQLite libraries which are compiled without this feature. To get loadable extension support, your Python must be compiled with - ``-–enable-loadable-sqlite-extensions`` option in ``PYTHON_CONFIGURE_OPTS``. + ``-–enable-loadable-sqlite-extensions`` option which is passed to + `configure `_ script. From 9a04f5249bdd1e75f8aa8faebe1fcac7e8c62684 Mon Sep 17 00:00:00 2001 From: Vladimir Date: Tue, 5 Jan 2021 09:04:05 -0800 Subject: [PATCH 4/5] Update sqlite3.rst Keep original lines --- Doc/library/sqlite3.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Doc/library/sqlite3.rst b/Doc/library/sqlite3.rst index b990d3b474b332..a2b4507a1ed941 100644 --- a/Doc/library/sqlite3.rst +++ b/Doc/library/sqlite3.rst @@ -1091,7 +1091,7 @@ committed: .. [#f1] The sqlite3 module is not built with loadable extension support by default, because some platforms (notably Mac OS X) have SQLite - libraries which are compiled without this feature. To get loadable extension - support, your Python must be compiled with + libraries which are compiled without this feature. To get loadable + extension support, your Python must be compiled with ``-–enable-loadable-sqlite-extensions`` option which is passed to `configure `_ script. From c6e5f91b474e15e3783012456f55a5ebb90fe1b6 Mon Sep 17 00:00:00 2001 From: Vladimir Date: Tue, 5 Jan 2021 16:01:38 -0800 Subject: [PATCH 5/5] Update sqlite3.rst Revert back some changes unrelated to the BPO. --- Doc/library/sqlite3.rst | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Doc/library/sqlite3.rst b/Doc/library/sqlite3.rst index a2b4507a1ed941..25a41033a0fbc5 100644 --- a/Doc/library/sqlite3.rst +++ b/Doc/library/sqlite3.rst @@ -1092,6 +1092,5 @@ committed: .. [#f1] The sqlite3 module is not built with loadable extension support by default, because some platforms (notably Mac OS X) have SQLite libraries which are compiled without this feature. To get loadable - extension support, your Python must be compiled with - ``-–enable-loadable-sqlite-extensions`` option which is passed to - `configure `_ script. + extension support, you must pass --enable-loadable-sqlite-extensions to + configure.