Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-91441: Clarify the docs of asyncio.loop.subprocess_exec() #91442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

tifv
Copy link
Contributor

@tifv tifv commented Apr 11, 2022

Clarify the documentation of stdin, stdout and stderr arguments of asyncio.loop.subprocess_exec().

(Not sure about my English, or the exact placement of the new paragraph.)

Clarify the documentation of stdin, stdout and stderr arguments of
asyncio.loop.subprocess_exec().
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the wording but I can't judge whether this is correct. There aren't any current unit tests that actually pass a file-like object to stdin/stdout/stderr.

Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @tifv

@willingc willingc merged commit 37e3755 into python:main Apr 26, 2023
itamaro pushed a commit to itamaro/cpython that referenced this pull request Apr 26, 2023
…ython#91442)

Clarify the docs of asyncio.loop.subprocess_exec()

Clarify the documentation of stdin, stdout and stderr arguments of
asyncio.loop.subprocess_exec().

Co-authored-by: Carol Willing <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news topic-asyncio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants