Use black for labels on lighter backgrounds

hugovk · hugovk · commit cee0046d155b · 2023-01-22T14:27:00.000+02:00
diff --git a/_static/devguide_overrides.css b/_static/devguide_overrides.css
@@ -47,30 +47,30 @@
 .release-cycle-chart .release-cycle-blob-label {
     /* white looks good on both light & dark */
     fill: white;
-    filter:
-        drop-shadow(1px 1px 0.5px rgba(0, 0, 0, 0.5))
-        drop-shadow(-1px 1px 0.5px rgba(0, 0, 0, 0.5))
-        drop-shadow(1px -1px 0.5px rgba(0, 0, 0, 0.5))
-        drop-shadow(-1px -1px 0.5px rgba(0, 0, 0, 0.5))
-        ;
 }
 
-.release-cycle-chart .release-cycle-blob-end-of-life {
+.release-cycle-chart .release-cycle-blob-label.release-cycle-blob-security,
+.release-cycle-chart .release-cycle-blob-label.release-cycle-blob-bugfix {
+    /* but use black to improve contrast for lighter backgrounds */
+    fill: black;
+}
+
+.release-cycle-chart .release-cycle-blob.release-cycle-blob-end-of-life {
     fill: #DD2200;
     stroke: #FF8888;
 }
 
-.release-cycle-chart .release-cycle-blob-security {
+.release-cycle-chart .release-cycle-blob.release-cycle-blob-security {
     fill: #FFDD44;
     stroke: #FF8800;
 }
 
-.release-cycle-chart .release-cycle-blob-bugfix {
+.release-cycle-chart .release-cycle-blob.release-cycle-blob-bugfix {
     fill: #00DD22;
     stroke: #008844;
 }
 
-.release-cycle-chart .release-cycle-blob-feature {
+.release-cycle-chart .release-cycle-blob.release-cycle-blob-feature {
     fill: #2222EE;
     stroke: #008888;
 }
diff --git a/_tools/release_cycle_template.svg.jinja b/_tools/release_cycle_template.svg.jinja
@@ -67,7 +67,7 @@
             ry="0.25em"
         />
         <text
-            class="release-cycle-blob-label"
+            class="release-cycle-blob-label release-cycle-blob-{{version.status}}"
             x="{{mid_x * SCALE}}"
             y="{{(y - 0.1) * SCALE}}"
             font-size="{{SCALE * 0.75}}"
diff --git a/include/release-cycle.svg b/include/release-cycle.svg
@@ -448,7 +448,7 @@
             ry="0.25em"
         />
         <text
-            class="release-cycle-blob-label"
+            class="release-cycle-blob-label release-cycle-blob-end-of-life"
             x="213.94127310061603"
             y="25.2"
             font-size="13.5"
@@ -478,7 +478,7 @@
             ry="0.25em"
         />
         <text
-            class="release-cycle-blob-label"
+            class="release-cycle-blob-label release-cycle-blob-end-of-life"
             x="351.2605749486653"
             y="52.199999999999996"
             font-size="13.5"
@@ -508,7 +508,7 @@
             ry="0.25em"
         />
         <text
-            class="release-cycle-blob-label"
+            class="release-cycle-blob-label release-cycle-blob-end-of-life"
             x="141.7478439425051"
             y="79.2"
             font-size="13.5"
@@ -538,7 +538,7 @@
             ry="0.25em"
         />
         <text
-            class="release-cycle-blob-label"
+            class="release-cycle-blob-label release-cycle-blob-end-of-life"
             x="199.758726899384"
             y="106.2"
             font-size="13.5"
@@ -568,7 +568,7 @@
             ry="0.25em"
         />
         <text
-            class="release-cycle-blob-label"
+            class="release-cycle-blob-label release-cycle-blob-end-of-life"
             x="295.33675564681727"
             y="133.20000000000002"
             font-size="13.5"
@@ -598,7 +598,7 @@
             ry="0.25em"
         />
         <text
-            class="release-cycle-blob-label"
+            class="release-cycle-blob-label release-cycle-blob-end-of-life"
             x="351.02340862423"
             y="160.20000000000002"
             font-size="13.5"
@@ -628,7 +628,7 @@
             ry="0.25em"
         />
         <text
-            class="release-cycle-blob-label"
+            class="release-cycle-blob-label release-cycle-blob-end-of-life"
             x="401.682135523614"
             y="187.20000000000002"
             font-size="13.5"
@@ -658,7 +658,7 @@
             ry="0.25em"
         />
         <text
-            class="release-cycle-blob-label"
+            class="release-cycle-blob-label release-cycle-blob-end-of-life"
             x="454.2381930184805"
             y="214.20000000000002"
             font-size="13.5"
@@ -688,7 +688,7 @@
             ry="0.25em"
         />
         <text
-            class="release-cycle-blob-label"
+            class="release-cycle-blob-label release-cycle-blob-end-of-life"
             x="497.6870636550308"
             y="241.20000000000002"
             font-size="13.5"
@@ -718,7 +718,7 @@
             ry="0.25em"
         />
         <text
-            class="release-cycle-blob-label"
+            class="release-cycle-blob-label release-cycle-blob-security"
             x="549.958521560575"
             y="268.2"
             font-size="13.5"
@@ -748,7 +748,7 @@
             ry="0.25em"
         />
         <text
-            class="release-cycle-blob-label"
+            class="release-cycle-blob-label release-cycle-blob-security"
             x="594.3560574948666"
             y="295.2"
             font-size="13.5"
@@ -778,7 +778,7 @@
             ry="0.25em"
         />
         <text
-            class="release-cycle-blob-label"
+            class="release-cycle-blob-label release-cycle-blob-security"
             x="628.6028747433265"
             y="322.2"
             font-size="13.5"
@@ -808,7 +808,7 @@
             ry="0.25em"
         />
         <text
-            class="release-cycle-blob-label"
+            class="release-cycle-blob-label release-cycle-blob-bugfix"
             x="663.181724845996"
             y="349.2"
             font-size="13.5"
@@ -838,7 +838,7 @@
             ry="0.25em"
         />
         <text
-            class="release-cycle-blob-label"
+            class="release-cycle-blob-label release-cycle-blob-bugfix"
             x="698.7566735112937"
             y="376.2"
             font-size="13.5"
@@ -868,7 +868,7 @@
             ry="0.25em"
         />
         <text
-            class="release-cycle-blob-label"
+            class="release-cycle-blob-label release-cycle-blob-feature"
             x="732.3868583162218"
             y="403.2"
             font-size="13.5"
