Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add a step-by-step list (with git commands) to the pullrequest page #103

Closed
@ezio-melotti

Description

@ezio-melotti

The pullrequest page should include a step-by-step list with the required git commands required to create a pull request.

The list should be something like:

  1. Create your fork of CPython by clicking on the "Fork" button on https://github.com/python/cpython
  2. Create a local clone of your fork by doing git clone https://github.com/your-username/cpython
  3. cd in the cpython dir and create a new branch with git checkout -b branch-name
  4. Edit the files that you want to change
  5. Run the tests with ./python -m test and make patchcheck
  6. Commit the changes with git commit -am 'bpo-NNNNN: message'
  7. Push the changes to your repo with git push -u origin branch-name
  8. Create a pull request by clicking on the "Create pull request" button
  9. Add a comment and submit the pull request.

The list can include links to relevant sections (e.g. how to run the tests) and mention that the first two steps are optional. Instead of a list, something like the following is also ok:

# clone your fork of CPython
git clone https://github.com/your-username/cpython
cd cpython
# create new branch
git checkout -b branch-name
# edit the files you want to change and run the tests
./python -m test
# check the patch
make patchcheck
# commit the changes
git commit -am 'bpo-NNNNN: message'
# push them to your fork
git push -u origin branch-name

This can be prefixed by a paragraph explaining how to create your own fork, and followed by one that explains how to create the PR after the push.

Also note that there's some overlapping with the committing page that also includes some command and some steps that should be included in this list (e.g. the minimal configuration and initial setup). I think it would be better to have everything in a single page with additional subsections for core-devs-specific steps.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions