Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add a mention to the correct workflow for WSL users building for Windows #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
augustogoulart opened this issue Oct 12, 2018 · 11 comments
Closed

Comments

@augustogoulart
Copy link
Contributor

When using the Windows Subsystem for Linux (WSL), if you git clone the project via Linux and tries to compile the project on Windows, Visual Studio will be able to see the project, but won't be able to compile the included files.
Since this is not a bug, I believe it would be nice to mention the correct workflow.

screenshot 2

@Mariatta
Copy link
Member

GitMate.io thinks possibly related issues are python/core-workflow#32 (Add the mention bot?), #202 (Mention core-workflow mailing list / repo), #54 (Streamline workflow), python/core-workflow#74 (Add bpo link to mention-bot when issue id provide), and #3 (Add Travis support).

@taleinat
Copy link
Contributor

@Mariatta

GitMate.io thinks possibly related issues are python/core-workflow#32 (Add the mention bot?), #202 (Mention core-workflow mailing list / repo), #54 (Streamline workflow), python/core-workflow#74 (Add bpo link to mention-bot when issue id provide), and #3 (Add Travis support).

Unfortunately, none of those is relevant.

@mariatta-bot
Copy link

Mariatta was mentioned, but she's out of open source for the rest of September 2018, and parts of October 2018 . Be aware she might not get to this until November 2018.
(I'm a bot)

@taleinat
Copy link
Contributor

taleinat commented Oct 13, 2018

I've reproduced this with the following steps:

  1. In an Ubuntu WSL shell: git clone --depth=1 https://github.com/python/cpython.git cpython_wsl_test
  2. In a cmd.exe shell:
    2.1 cd cpython_wsl_test
    2.2 PCbuild\build.bat

I get the same errors reported by @augustogoulart.

@zware, could you try to reproduce this on your setup? Also, any thoughts on the reason for this strange behavior?

(Win10 Pro 64-bit with Ubuntu 18.04 64-bit in WSL)

@willingc
Copy link
Collaborator

@augustogoulart @taleinat Nice to see this being worked through 😄 I'm happy to test the instructions after you finish troubleshooting the errors with @zware.

@taleinat
Copy link
Contributor

taleinat commented Oct 13, 2018

@willingc, the current suggested resolution is "this doesn't work, don't do it!", adding a note to this effect to the dev guide.

I do think we should also mention what should be done, which is basically to use a build of git targeted for Windows, e.g. the official one from https://git-scm.com (previously known as "Git for Windows"), from a "native" windows environment such a cmd.exe command prompt or PowerShell.

@zware
Copy link
Member

zware commented Oct 15, 2018

I tried the same steps (though I named my checkout 'wsl_cpython' and did PCbuild\build.bat -d), and had no problems.

@taleinat
Copy link
Contributor

@zware, could it be different git autocrlf settings perhaps? Or something similar?

@zware
Copy link
Member

zware commented Oct 22, 2018

Sorry I've been blocking this and haven't gotten back to it yet! However, I still can't reproduce the issue. It's possible that my Windows (10.0.16299.665), WSL distribution (Ubuntu 16.04.4), or git (2.7.4) are significantly older than what you're using, but the whole issue doesn't make sense to me. When git checks out the files, they're just files on disk and the build system doesn't look for or care about Git (except to set variables for the version string, but any errors there are silenced and ignored). Can you confirm that the checkout is actually complete, and the files do appear to be where they should be?

I suppose it's possible that autocrlf is causing issues; I don't have it set at all and rely on .gitattributes instead.

Are you making your checkout within the Linux filesystem, or the Windows filesystem (/mnt/c/)?

@augustogoulart
Copy link
Contributor Author

@zware these are the steps I'm following to reproduce the error.

Windows 10.0.17134 build 17143, WSL Debian 9 (stretch) and git 2.11 installed on Linux, and git 2.19.1.windows.1 on Windows. Compiler Microsoft (R) C/C++ Optimizing Compiler Version 19.15.26730.

Checkout withing Linux. path: /mnt/c/Users/augus/Workspace

image

Compiling on Windows. Fails because Visual Studio can not find the files:

image

Checking each file path, the file exists:

image

@JulienPalard
Copy link
Member

Can this be a permission issue? Not familiar with Windows permissions though.

@brettcannon brettcannon changed the title Add a mention to the correct workflow for WSL users Add a mention to the correct workflow for WSL users building for Windows Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants