Other conditions were using self.quick.

JulienPalard · JulienPalard · commit 1813f8c3213e · 2023-01-04T08:57:44.000+01:00
diff --git a/build_docs.py b/build_docs.py
@@ -36,7 +36,7 @@
 import sys
 import time
 from bisect import bisect_left as bisect
-from collections import OrderedDict, namedtuple
+from collections import OrderedDict
 from contextlib import contextmanager
 from pathlib import Path
 from string import Template
@@ -637,15 +637,32 @@ def setup_logging(log_directory: Path):
     logging.getLogger().setLevel(logging.DEBUG)
 
 
-class DocBuilder(
-    namedtuple(
-        "DocBuilder",
-        "version, language, build_root, www_root, quick, group, "
-        "log_directory, skip_cache_invalidation, theme",
-    )
-):
+@dataclass
+class DocBuilder:
     """Builder for a cpython version and a language."""
 
+    version: Version
+    language: Language
+    build_root: Path
+    www_root: Path
+    quick: bool
+    group: str
+    log_directory: Path
+    skip_cache_invalidation: bool
+    theme: Path
+
+    @property
+    def full_build(self):
+        """Tell if a full build is needed.
+
+        A full build is slow, it builds pdf, txt, epub, texinfo, and
+        archives everything.
+
+        A partial build only builds HTML and does not archive, it's
+        fast.
+        """
+        return not self.quick and not self.language.html_only
+
     def run(self):
         """Build and publish a Python doc, for a language, and a version."""
         try:
@@ -718,7 +735,7 @@ def build(self):
                 if self.version.status in ("in development", "pre-release")
                 else "stable"
             )
-            + ("-html" if self.quick or self.language.html_only else "")
+            + ("" if self.full_build  else "-html")
         )
         logging.info("Running make %s", maketarget)
         python = self.venv / "bin" / "python"
@@ -830,11 +847,14 @@ def copy_build_to_webroot(self):
                 ";",
             ]
         )
-        if self.quick:
+        if self.full_build:
             run(
                 [
                     "rsync",
                     "-a",
+                    "--delete-delay",
+                    "--filter",
+                    "P archives/",
                     str(self.checkout / "Doc" / "build" / "html") + "/",
                     target,
                 ]
@@ -844,14 +864,11 @@ def copy_build_to_webroot(self):
                 [
                     "rsync",
                     "-a",
-                    "--delete-delay",
-                    "--filter",
-                    "P archives/",
                     str(self.checkout / "Doc" / "build" / "html") + "/",
                     target,
                 ]
             )
-        if not self.quick:
+        if self.full_build:
             logging.debug("Copying dist files")
             run(
                 [
@@ -986,7 +1003,7 @@ def purge_path(www_root: Path, path: Path):
     run(["curl", "-XPURGE", f"https://docs.python.org/{{{','.join(to_purge)}}}"])
 
 
-def main():
+def main() -> None:
     """Script entry point."""
     args = parse_args()
     setup_logging(args.log_directory)
