-
-
Notifications
You must be signed in to change notification settings - Fork 63
smart quotes breaks API reference #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Looks fixed by #33 |
Fixed (I just upgraded sphinx to the latest version, they fixed it). |
@JulienPalard In Japanese, we want use
Could you consider again disabling smart quotes? python-doc-ja/python-doc-ja#774 (comment) As @cocoatomo said, we can disable it by putting
|
python-doc-ja/python-doc-ja#774 (comment) @cocoatomo suggests this configuration for
With this config, |
That's nice, so we can commit the file in cpython if this is the case, I'm trying it right now. |
I tried it and got the following results: No diff for en and fr as expected, and a diff for japanese as following:
and
I'm opening an issue on b.p.o and a PR. |
Opened the PR: python/cpython#4006 |
python/cpython#4006 has been merged. |
Same issue is now occurring on Japanese translation on docs.python.org.
docutils.conf does exist on https://github.com/python/cpython/blob/master/Doc/docutils.conf, I would like to reopen this issue. |
@JulienPalard Would you like to check the comment above? |
Hi @cocoatomo, I tried disabling smartquotes completly, on
(Last one diff on the simple quote of "Developer's" from U+2019 to U+0027.) How does it looks to you? Sadly it diff a lot on english and french version too (U+2019, U+201C, U+201D, ...). |
That result looks good, but disabling smartquotes has bad effect on French version, which is quite undesirable for me. So, I suggest to use configuration smartquotes_excludes in conf.py. |
So, upgrading to sphinx 1.6.6 should do it. I'm trying a local build with 1.7.2. |
Since this commit bumps Sphinx version to 1.7.2, smartquotes was disabledfor Japanese HTML builds and will not break Japanese HTML documents. Finally, this issue seems resolved with the better way. |
Nice to hear :) |
Ref: python-doc-ja/python-doc-ja#771
When Japanese quotes (e.g.
『
,「
) are suitable, we use them in translation.So we don't want to translate English quotes (
"
,'
) to Japanese quotes automatically.Would you disable smart-quotes option in docutils.conf?
The text was updated successfully, but these errors were encountered: