Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test_package_discovery fails on Python 3.8 #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jaraco opened this issue Oct 22, 2020 · 3 comments
Closed

test_package_discovery fails on Python 3.8 #93

jaraco opened this issue Oct 22, 2020 · 3 comments
Labels
duplicate This issue or pull request already exists

Comments

@jaraco
Copy link
Member

jaraco commented Oct 22, 2020

In GitLab by @kapsh on Oct 12, 2019, 13:15

Run tox -e py38 -- -fv

Result:

py38 develop-inst-noop: /home/kapsh/repos/pytest_friends/importlib_metadata
py38 installed: atomicwrites==1.3.0,attrs==19.2.0,-e git+https://gitlab.com/python-devs/importlib_metadata@08a3782fc382d4d2671da66a3bc0e11695d091f1#egg=importlib_metadata,more-itertools==7.2.0,packaging==19.2,pluggy==0.13.0,py==1.8.0,pyparsing==2.4.2,pytest==5.2.1,six==1.12.0,wcwidth==0.1.7,zipp==0.6.0
py38 run-test-pre: PYTHONHASHSEED='3503751603'
py38 run-test: commands[0] | python -m unittest discover -f
..........................F
======================================================================
FAIL: test_package_discovery (importlib_metadata.tests.test_main.DiscoveryTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/kapsh/repos/pytest_friends/importlib_metadata/importlib_metadata/tests/test_main.py", line 160, in test_package_discovery
    assert all(
AssertionError

----------------------------------------------------------------------
Ran 27 tests in 0.093s

FAILED (failures=1)

It seems that isinstance(dist, Distribution) returns False for some of distributions. This test passes when running on Python 3.7.

Python 3.8.0rc1, importlib_metadata 08a3782 (latest master).
@jaraco jaraco added the duplicate This issue or pull request already exists label Oct 22, 2020
@jaraco
Copy link
Member Author

jaraco commented Oct 22, 2020

In GitLab by @doko42 on Oct 19, 2019, 07:50

also seen with the final 3.8.0 release

@jaraco
Copy link
Member Author

jaraco commented Oct 22, 2020

In GitLab by @jaraco on Oct 26, 2019, 18:24

Yes, I see this too. This issue is related to #91. The issue is essentially that the Distribution object exists both in stdlib and in importlib_metadata, far too reminiscent of similar errors encountered between Setuptools and distutils. I'm pretty sure that the fix for #91 will address this issue, so I'm going to close it as duplicate (even though they're coming from a different perspective and symptom).

@jaraco
Copy link
Member Author

jaraco commented Oct 22, 2020

In GitLab by @jaraco on Oct 26, 2019, 18:24

closed

@jaraco jaraco closed this as completed Oct 22, 2020
jaraco added a commit that referenced this issue Dec 21, 2023
@jaraco
Include all package data. Closes #93.
2707fb7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jaraco