Restore removed builtin_type() api method (#11932)

JukkaL · web-flow · commit 10f6e4dfd416 · 2022-01-07T14:53:26.000Z
It shouldn't be used for new code, but adding it back makes it unnecessary to update existing plugins that no longer worked with mypy 0.930. Related issue: dropbox/sqlalchemy-stubs#232
diff --git a/mypy/plugin.py b/mypy/plugin.py
@@ -257,6 +257,12 @@ def named_type(self, fullname: str,
         """Construct an instance of a builtin type with given type arguments."""
         raise NotImplementedError
 
+    @abstractmethod
+    def builtin_type(self, fully_qualified_name: str) -> Instance:
+        """Legacy function -- use named_type() instead."""
+        # NOTE: Do not delete this since many plugins may still use it.
+        raise NotImplementedError
+
     @abstractmethod
     def named_type_or_none(self, fullname: str,
                            args: Optional[List[Type]] = None) -> Optional[Instance]:
diff --git a/mypy/semanal.py b/mypy/semanal.py
@@ -4567,6 +4567,10 @@ def named_type_or_none(self, fullname: str,
             return Instance(node, args)
         return Instance(node, [AnyType(TypeOfAny.unannotated)] * len(node.defn.type_vars))
 
+    def builtin_type(self, fully_qualified_name: str) -> Instance:
+        """Legacy function -- use named_type() instead."""
+        return self.named_type(fully_qualified_name)
+
     def lookup_current_scope(self, name: str) -> Optional[SymbolTableNode]:
         if self.locals[-1] is not None:
             return self.locals[-1].get(name)
