Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Move to using package_data to install typeshed and xml files. #4143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
emmatyping opened this issue Oct 20, 2017 · 5 comments
Closed

Move to using package_data to install typeshed and xml files. #4143

emmatyping opened this issue Oct 20, 2017 · 5 comments
Labels
priority-1-normal refactoring Changing mypy's internals

Comments

@emmatyping
Copy link
Member

emmatyping commented Oct 20, 2017 •
edited
Loading

Currently, we use data_files to distribute typeshed and xml files. The prefix under which data_files is installed is not exposed publicly, which has lead to complexities and issues with resolving typeshed's install location such as #4142.

Therefore, I propose we move to package_data. This will install typeshed and the xml files into site-packages/mypy/typeshed and site-packages/mypy/xml. This will be much easier to find, and should avoid all of the intricacies in resolving the system prefix.
@emmatyping
Copy link
Member Author

Well, annoyingly, it appears this won't be possible, unless we require pip install . to use admin on Windows (see pypa/pip#1006).

However, python3 setup.py install will work fine, as well as sdist, bdist_wheel, and just about any other installation I can think of (including oddly pip install -e ., which is a developer install). The underlying issue is typeshed symlinks, so we could fix that and everything would work, but Im not sure the path forward on that is the clearest to me.

@JelleZijlstra
Copy link
Member

Wasn't that issue fixed in pypa/pip#1311?

@emmatyping
Copy link
Member Author

It was fixed, but it seems that the fix requires administrator access on Windows see pypa/pip#1311 (comment)

I tested it myself and it fails without privileges.

@JukkaL
Copy link
Collaborator

JukkaL commented Oct 26, 2017

I think that we should get rid of typeshed symlinks.

@gvanrossum gvanrossum mentioned this issue Nov 8, 2017
Merged
@emmatyping emmatyping mentioned this issue Jul 3, 2018
Closed
@emmatyping
Copy link
Member Author

Closing in favor of #5307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority-1-normal refactoring Changing mypy's internals
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JelleZijlstra @JukkaL @emmatyping