-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Make targets don't use venv #2403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I don't know what the precedent is here, but I would be wary of doing this -- the user may have a general "documentation" venv, or use an alternate package manager (conda) -- combining the two might cause problems. I don't understand (1), perhaps as of an ignorance of how things work on Unix -- how would one specify "Python 3, but search PATH for the executable"? A |
I don't have a clear solution for all the cases, other than the most useful thing would be venv-by-default with the option to explicitly not run in a venv. The point is rather moot due to #2402 though. |
My make-fu is pretty weak as I'm mostly used to cross-platform tools like tox/nox, but it always did strike me as odd that there was a Like @AA-Turner I'm a little confused about 3., since it just says |
For reference, the CPython docs build uses a cd Doc
make venv
make html https://devguide.python.org/documenting/#building-the-documentation It also has https://github.com/python/cpython/blob/8714b6fa27271035dd6dd3514e283f92d669321d/Doc/Makefile#L7 |
Please see PR #2408 to first create a venv using the Python version supplied to |
When I run
make pep0684.html
, it fails because docutils & Pygments are not installed. This demonstrates several problems:make
with that venv activated$(PYTHON)
to /usr/bin/python3, so requirements.txt must be installed on the system Python (though usually under $HOME/.local)make venv
creates a venv but it is pointless due to the above problems(2) and (3) are mostly addressed by #2402. However, (1) and (2) are not. I would expect most of the make targets to automatically create a venv with requirements.txt installed and run in that venv. (Aside: pre-config should be added to requirements.txt.)
The text was updated successfully, but these errors were encountered: