Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Footer: "Last updated on None" #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hugovk opened this issue Mar 25, 2024 · 2 comments · Fixed by #183
Closed

Footer: "Last updated on None" #182

hugovk opened this issue Mar 25, 2024 · 2 comments · Fixed by #183
Labels
bug

Comments

@hugovk
Copy link
Member

hugovk commented Mar 25, 2024

The typing docs use this theme:

https://typing.readthedocs.io/en/latest/

The footer says:

Last updated on None.

CPython docs has:

Last updated on Mar 23, 2024 (19:01 UTC).

Maybe typing is missing something in conf.py, or maybe this theme is making an assumption.
@hugovk hugovk added the bug label Mar 25, 2024
@ezio-melotti
Copy link
Member

This?
https://github.com/python/cpython/blob/eebea7e515462b503632ada74923ec3246599c9c/Doc/conf.py#L341-L342

@hugovk
Copy link
Member Author

hugovk commented Mar 25, 2024

Yep, that looks like it.

The comment used to be:

# If not '', a 'Last updated on:' timestamp is inserted at every page bottom,
# using the given strftime format.

python/cpython@6c214de

We should probably default to not showing the line if the config is missing, or use a default timestamp. Basically do whatever the earlier behaviour was.

@hugovk hugovk mentioned this issue Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only show 'Last updated on ...' when last_updated defined hugovk/python-docs-theme
2 participants
@hugovk @ezio-melotti