Thanks to visit codestin.com
Credit goes to github.com

Skip to content

idea: add 'set -u' for build.sh and update.sh #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rffontenelle opened this issue Nov 24, 2023 · 2 comments · Fixed by #339
Closed

idea: add 'set -u' for build.sh and update.sh #335

rffontenelle opened this issue Nov 24, 2023 · 2 comments · Fixed by #339

Comments

@rffontenelle
Copy link
Contributor

They both have set -ex. Considering that they rely on the environment variable $LOCALE, how about adding set -u as well to error in case $LOCALE is not set at running time? i believe it is a fairly good safety resource.
@Dumeng
Copy link
Collaborator

Dumeng commented Nov 29, 2023

Actually, we set the env var in the below workflow template. So, it should be fine in the GitHub Action environments.

python-docs-zh-cn/.github/workflows/sync.yml

Line 20 in 12fad78

LOCALE: zh_CN

But I agree it might be a problem if someone forked the scripts or ran them in local environments. A PR is welcome.

@rffontenelle rffontenelle mentioned this issue Nov 29, 2023
Merged
@rffontenelle
Copy link
Contributor Author

Yeah, I notice you've got it covered. My suggestion is really more an extra precaution. PR sent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Error on unset variable in scritps rffontenelle/python-docs-zh-cn
2 participants
@rffontenelle @Dumeng