Tighten return type of OpenSSL Connection.get_protocol_name() (#5972)

jdufresne · web-flow · commit b50ebafa7913 · 2021-08-27T10:54:27.000-07:00
The method always returns a str. See implementation at: https://github.com/pyca/pyopenssl/blob/30e82d4ba5e3817a77e212540477da701460e988/src/OpenSSL/SSL.py#L2420-L2430 If version were ever None, it would raise an exception on the .decode() line.
diff --git a/stubs/pyOpenSSL/OpenSSL/SSL.pyi b/stubs/pyOpenSSL/OpenSSL/SSL.pyi
@@ -131,7 +131,7 @@ class Connection(object):
     def get_peer_cert_chain(self) -> list[X509]: ...
     def get_alpn_proto_negotiated(self) -> bytes: ...
     def get_cipher_name(self) -> str | None: ...
-    def get_protocol_version_name(self) -> str | None: ...
+    def get_protocol_version_name(self) -> str: ...
     def get_shutdown(self) -> int: ...
     def get_app_data(self) -> Any: ...
     def set_app_data(self, data: Any) -> None: ...
