From 4c1f075dcccc08ebf90f415f447218df3c71b762 Mon Sep 17 00:00:00 2001 From: Sebastian Rittau Date: Fri, 21 Mar 2025 16:33:34 +0100 Subject: [PATCH 1/6] Sample text for closing future stdlib PRs --- MAINTAINERS.md | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/MAINTAINERS.md b/MAINTAINERS.md index f36c28758f52..6c0cb6a41f30 100644 --- a/MAINTAINERS.md +++ b/MAINTAINERS.md @@ -81,3 +81,18 @@ message when closing the PR. Example message: after three months of inactivity. If you are still interested, please feel free to open a new PR (or ping us to reopen this one). + +### Closing PRs for future standard library changes + +*See also the [guidelines in the CONTRIBUTING file](./CONTRIBUTING.md#standard-library-stubs).* + +When rejecting a PR for a change for a future Python version, use a message +like: + + Thanks for contributing! Unfortunately, we only accept pull requests to the + standard library for future Python versions after the first beta version + has been released. This is in part to prevent churn in the stubs, and in + part because the testing infrastructure for the future version is not yet + in place. When the first beta version has been releasd and this PR is + still relevant, please feel free to leave a comment here to reopen it. + Alternatively, you can open a new PR. From db40f1814167bce8a1b53affa6c5736782439d52 Mon Sep 17 00:00:00 2001 From: Sebastian Rittau Date: Fri, 21 Mar 2025 16:36:15 +0100 Subject: [PATCH 2/6] Link to CONTRIBUTING in text --- MAINTAINERS.md | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/MAINTAINERS.md b/MAINTAINERS.md index 6c0cb6a41f30..9e3cf717b411 100644 --- a/MAINTAINERS.md +++ b/MAINTAINERS.md @@ -89,10 +89,11 @@ message when closing the PR. Example message: When rejecting a PR for a change for a future Python version, use a message like: - Thanks for contributing! Unfortunately, we only accept pull requests to the - standard library for future Python versions after the first beta version - has been released. This is in part to prevent churn in the stubs, and in - part because the testing infrastructure for the future version is not yet - in place. When the first beta version has been releasd and this PR is - still relevant, please feel free to leave a comment here to reopen it. - Alternatively, you can open a new PR. + Thanks for contributing! Unfortunately, + [as outlined in our CONTRIBUTING document](./CONTRIBUTING.md#standard-library-stubs) + we only accept pull requests to the standard library for future Python + versions after the first beta version has been released. This is in part to + prevent churn in the stubs, and in part because the testing infrastructure + for the future version is not yet in place. When the first beta version has + been releasd and this PR is still relevant, please feel free to leave a + comment here to reopen it. Alternatively, you can open a new PR. From 22682e2ec939f69bcd5470e1040f8b11e04627bf Mon Sep 17 00:00:00 2001 From: Sebastian Rittau Date: Fri, 21 Mar 2025 16:38:03 +0100 Subject: [PATCH 3/6] Move onto one line for easier c&p --- MAINTAINERS.md | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/MAINTAINERS.md b/MAINTAINERS.md index 9e3cf717b411..7145dd1ee070 100644 --- a/MAINTAINERS.md +++ b/MAINTAINERS.md @@ -89,11 +89,4 @@ message when closing the PR. Example message: When rejecting a PR for a change for a future Python version, use a message like: - Thanks for contributing! Unfortunately, - [as outlined in our CONTRIBUTING document](./CONTRIBUTING.md#standard-library-stubs) - we only accept pull requests to the standard library for future Python - versions after the first beta version has been released. This is in part to - prevent churn in the stubs, and in part because the testing infrastructure - for the future version is not yet in place. When the first beta version has - been releasd and this PR is still relevant, please feel free to leave a - comment here to reopen it. Alternatively, you can open a new PR. + Thanks for contributing! Unfortunately, [as outlined in our CONTRIBUTING document](./CONTRIBUTING.md#standard-library-stubs) we only accept pull requests to the standard library for future Python versions after the first beta version has been released. This is in part to prevent churn in the stubs, and in part because the testing infrastructure for the future version is not yet in place. When the first beta version has been releasd and this PR is still relevant, please feel free to leave a comment here to reopen it. Alternatively, you can open a new PR. From bc81def11d5633b791ce953a712fb26fce2527d2 Mon Sep 17 00:00:00 2001 From: Sebastian Rittau Date: Fri, 21 Mar 2025 16:38:12 +0100 Subject: [PATCH 4/6] Move onto one line for easier c&p --- MAINTAINERS.md | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/MAINTAINERS.md b/MAINTAINERS.md index 7145dd1ee070..35e02a164b8a 100644 --- a/MAINTAINERS.md +++ b/MAINTAINERS.md @@ -77,10 +77,7 @@ blocker is, usually with a link to an open issue in another project. We want to maintain a welcoming atmosphere for contributors, so use a friendly message when closing the PR. Example message: - Thanks for contributing! I'm closing this PR for now, because it still - - after three months of inactivity. If you are still interested, please feel free to open - a new PR (or ping us to reopen this one). + Thanks for contributing! I'm closing this PR for now, because it still after three months of inactivity. If you are still interested, please feel free to open a new PR (or ping us to reopen this one). ### Closing PRs for future standard library changes From 0ab92bc5e506149d28e25136348943d9f6ba278f Mon Sep 17 00:00:00 2001 From: Sebastian Rittau Date: Fri, 21 Mar 2025 17:20:51 +0100 Subject: [PATCH 5/6] Fixes from PR reviews --- MAINTAINERS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS.md b/MAINTAINERS.md index 35e02a164b8a..aa91867ecd45 100644 --- a/MAINTAINERS.md +++ b/MAINTAINERS.md @@ -86,4 +86,4 @@ message when closing the PR. Example message: When rejecting a PR for a change for a future Python version, use a message like: - Thanks for contributing! Unfortunately, [as outlined in our CONTRIBUTING document](./CONTRIBUTING.md#standard-library-stubs) we only accept pull requests to the standard library for future Python versions after the first beta version has been released. This is in part to prevent churn in the stubs, and in part because the testing infrastructure for the future version is not yet in place. When the first beta version has been releasd and this PR is still relevant, please feel free to leave a comment here to reopen it. Alternatively, you can open a new PR. + Thanks for contributing! Unfortunately, [as outlined in our CONTRIBUTING document](https://github.com/python/typeshed/blob/main/CONTRIBUTING.md#standard-library-stubs) we only accept pull requests to the standard library for future Python versions after the first beta version has been released. This is in part to prevent churn in the stubs, and in part because the testing infrastructure for the future version is not yet in place. When the first beta version has been released and this PR is still relevant, please feel free to leave a comment here to reopen it. Alternatively, you can open a new PR. From e2bfe74f8d0dc143a5d6d5cfd5b5c1a60e604a4d Mon Sep 17 00:00:00 2001 From: Sebastian Rittau Date: Thu, 27 Mar 2025 12:47:00 +0100 Subject: [PATCH 6/6] Switch alternatives for reopening around --- MAINTAINERS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS.md b/MAINTAINERS.md index aa91867ecd45..52e86aeaf8ea 100644 --- a/MAINTAINERS.md +++ b/MAINTAINERS.md @@ -86,4 +86,4 @@ message when closing the PR. Example message: When rejecting a PR for a change for a future Python version, use a message like: - Thanks for contributing! Unfortunately, [as outlined in our CONTRIBUTING document](https://github.com/python/typeshed/blob/main/CONTRIBUTING.md#standard-library-stubs) we only accept pull requests to the standard library for future Python versions after the first beta version has been released. This is in part to prevent churn in the stubs, and in part because the testing infrastructure for the future version is not yet in place. When the first beta version has been released and this PR is still relevant, please feel free to leave a comment here to reopen it. Alternatively, you can open a new PR. + Thanks for contributing! Unfortunately, [as outlined in our CONTRIBUTING document](https://github.com/python/typeshed/blob/main/CONTRIBUTING.md#standard-library-stubs) we only accept pull requests to the standard library for future Python versions after the first beta version has been released. This is in part to prevent churn in the stubs, and in part because the testing infrastructure for the future version is not yet in place. Please feel free to open a new PR when the first beta version has been released. Alternatively, if this PR is still relevant, you can leave a comment here to reopen it.