yaml.dump(..., stream) is optional #2288
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<http://pyyaml.org/wiki/PyYAMLDocumentation#dumping-yaml> > yaml.dump accepts the second *optional* argument, which must be an open > text or binary file.
|
Thanks for your contribution! I don't think the documentation you cite is persuasive, because it could as well be referring to an optional argument in the sense of one that may be omitted, not of one that may be None. But these functions do in fact accept None as an argument, so I'll merge this as soon as Travis passes. |
|
No need to close the PR; I would actually like to get this fix into typeshed. |
|
I missed two other functions and had to ammend the commit. I canceled the pull request to not waste your time, but you're too fast ;-) See #2289 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://pyyaml.org/wiki/PyYAMLDocumentation#dumping-yaml