[2.7] bpo-33026: Fix jumping out of "with" block by setting f_lineno. (pythonGH-6026). (pythonGH-6074) (pythonGH-6076)

miss-islington · serhiy-storchaka · serhiy-storchaka · commit 3854f5885edc · 2018-03-11T10:55:59.000+02:00
(cherry picked from commit 26c9f56) (cherry picked from commit 04aadf2) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
diff --git a/Lib/test/test_sys_settrace.py b/Lib/test/test_sys_settrace.py
@@ -723,6 +723,34 @@ def test_jump_across_with(output):
         with tracecontext(output, 4):
             output.append(5)
 
+    @jump_test(4, 5, [1, 3, 5, 6])
+    def test_jump_out_of_with_block_within_for_block(output):
+        output.append(1)
+        for i in [1]:
+            with tracecontext(output, 3):
+                output.append(4)
+            output.append(5)
+        output.append(6)
+
+    @jump_test(4, 5, [1, 2, 3, 5, -2, 6])
+    def test_jump_out_of_with_block_within_with_block(output):
+        output.append(1)
+        with tracecontext(output, 2):
+            with tracecontext(output, 3):
+                output.append(4)
+            output.append(5)
+        output.append(6)
+
+    @jump_test(5, 6, [2, 4, 6, 7])
+    def test_jump_out_of_with_block_within_finally_block(output):
+        try:
+            output.append(2)
+        finally:
+            with tracecontext(output, 4):
+                output.append(5)
+            output.append(6)
+        output.append(7)
+
     @jump_test(8, 11, [1, 3, 5, 11, 12])
     def test_jump_out_of_complex_nested_blocks(output):
         output.append(1)
diff --git a/Misc/NEWS.d/next/Core and Builtins/2018-03-08-09-48-38.bpo-33026.QZA3Ba.rst b/Misc/NEWS.d/next/Core and Builtins/2018-03-08-09-48-38.bpo-33026.QZA3Ba.rst
@@ -0,0 +1 @@
+Fixed jumping out of "with" block by setting f_lineno.
diff --git a/Objects/frameobject.c b/Objects/frameobject.c
@@ -340,6 +340,11 @@ frame_setlineno(PyFrameObject *f, PyObject* p_new_lineno)
             PyObject *v = (*--f->f_stacktop);
             Py_DECREF(v);
         }
+        if (b->b_type == SETUP_WITH) {
+            /* Pop the exit function. */
+            PyObject *v = (*--f->f_stacktop);
+            Py_DECREF(v);
+        }
     }
 
     /* Finally set the new f_lineno and f_lasti and return OK. */

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Fixed jumping out of "with" block by setting f_lineno.`
Original file line number	Diff line number	Diff line change
`@@ -340,6 +340,11 @@ frame_setlineno(PyFrameObject f, PyObject p_new_lineno)`
`340`	`340`	`PyObject v = (--f->f_stacktop);`
`341`	`341`	`Py_DECREF(v);`
`342`	`342`	`}`
	`343`	`+ if (b->b_type == SETUP_WITH) {`
	`344`	`+ /* Pop the exit function. */`
	`345`	`+ PyObject v = (--f->f_stacktop);`
	`346`	`+ Py_DECREF(v);`
	`347`	`+ }`
`343`	`348`	`}`
`344`	`349`
`345`	`350`	`/* Finally set the new f_lineno and f_lasti and return OK. */`