chore: add testing of Python 3.14

JohnVillalovos · JohnVillalovos · commit 642ea089ad03 · 2024-10-22T22:42:51.000-07:00
Also fix __annotations__ not working in Python 3.14 by using the annotation on the 'class' instead of on the 'instance' Closes: #3013
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -36,10 +36,8 @@ jobs:
             toxenv: py312,smoke
           - version: "3.13"
             toxenv: py313,smoke
-          # NOTE(jlvillal): 2024-10-17: Enable this once we fix
-          # https://github.com/python-gitlab/python-gitlab/issues/3013
-          # - version: "3.14.0-alpha - 3.14" # SemVer's version range syntax
-          #   toxenv: py314,smoke
+          - version: "3.14.0-alpha - 3.14" # SemVer's version range syntax
+            toxenv: py314,smoke
         include:
           - os: macos-latest
             python:
diff --git a/gitlab/base.py b/gitlab/base.py
@@ -201,12 +201,12 @@ def _create_managers(self) -> None:
         # NOTE(jlvillal): We are creating our managers by looking at the class
         # annotations. If an attribute is annotated as being a *Manager type
         # then we create the manager and assign it to the attribute.
-        for attr, annotation in sorted(self.__annotations__.items()):
+        for attr, annotation in sorted(self.__class__.__annotations__.items()):
             # We ignore creating a manager for the 'manager' attribute as that
             # is done in the self.__init__() method
             if attr in ("manager",):
                 continue
-            if not isinstance(annotation, (type, str)):
+            if not isinstance(annotation, (type, str)):  # pragma: no cover
                 continue
             if isinstance(annotation, type):
                 cls_name = annotation.__name__
