feat: usernames support for MR approvals

nickbroon · nejch · commit a2b8c8ccfb5d · 2023-04-19T11:33:26.000+02:00
This can be used instead of 'user_ids' See: https://docs.gitlab.com/ee/api/merge_request_approvals.html#create-project-level-rule
diff --git a/gitlab/v4/objects/merge_request_approvals.py b/gitlab/v4/objects/merge_request_approvals.py
@@ -63,7 +63,7 @@ class ProjectApprovalRuleManager(
     _from_parent_attrs = {"project_id": "id"}
     _create_attrs = RequiredOptional(
         required=("name", "approvals_required"),
-        optional=("user_ids", "group_ids", "protected_branch_ids"),
+        optional=("user_ids", "group_ids", "protected_branch_ids", "usernames"),
     )
 
 

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ class ProjectApprovalRuleManager(`
`63`	`63`	`_from_parent_attrs = {"project_id": "id"}`
`64`	`64`	`_create_attrs = RequiredOptional(`
`65`	`65`	`required=("name", "approvals_required"),`
`66`		`- optional=("user_ids", "group_ids", "protected_branch_ids"),`
	`66`	`+ optional=("user_ids", "group_ids", "protected_branch_ids", "usernames"),`
`67`	`67`	`)`
`68`	`68`
`69`	`69`