Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Breakage with Gitlab 16.0 release #2563

Open
@zampierilucas

Description

@zampierilucas

With the 16.0 release, Gitlab is deprecating the "/approvals" api[1], and I noticed that python-gitlab still uses in:

class ProjectMergeRequestApprovalManager(GetWithoutIdMixin, UpdateMixin, RESTManager):
    _path = "/projects/{project_id}/merge_requests/{mr_iid}/approvals"

and

class ProjectApprovalManager(GetWithoutIdMixin, UpdateMixin, RESTManager):
    _path = "/projects/{project_id}/approvals"

Is this going to break any functionality of python-gitlab? And should those classes be removed?

  1. https://docs.gitlab.com/ee/update/deprecations?removal_milestone=16.0#changing-merge-request-approvals-with-the-approvals-api-endpoint

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions