From 4efd7e06ec5cdec32ac55c6dd5212c5d28c8b20b Mon Sep 17 00:00:00 2001 From: Erik Welch Date: Thu, 22 Jun 2023 16:26:07 -0500 Subject: [PATCH 1/4] Investigate awkward test failure --- .github/workflows/test_and_build.yml | 5 +++++ graphblas/tests/test_io.py | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test_and_build.yml b/.github/workflows/test_and_build.yml index bfad18a2e..b9bbede83 100644 --- a/.github/workflows/test_and_build.yml +++ b/.github/workflows/test_and_build.yml @@ -92,6 +92,7 @@ jobs: matrix: os: ["ubuntu-latest", "macos-latest", "windows-latest"] slowtask: ["pytest_normal", "pytest_bizarro", "notebooks"] + akver: ["2.2.2", "2.2.1", "2.2.0", "2.1.4", "2.1.3", "2.1.2", "2.1.1", "2.1.0", "2.0.10", "2.0.9", "2.0.8", "2.0.7", "2.0.6", "2.0.5", "1.10.3", "1.10.2", "1.10.1", "1.9.0"] env: # Wheels on OS X come with an OpenMP that conflicts with OpenMP from conda-forge. # Setting this is a workaround. @@ -227,6 +228,10 @@ jobs: numbaver=$(python -c 'import random ; print(random.choice(["=0.56", "=0.57", ""]))') fi fmm=fast_matrix_market${fmmver} + akver=${{ matrix.akver }} + if [[ ${{ startsWith(steps.pyver.outputs.selected, '3.11') }} == true && ${awkward} == "awkward=1.9.0"]]; then + akver="" + fi awkward=awkward${akver} if [[ ${{ contains(steps.pyver.outputs.selected, 'pypy') || startsWith(steps.pyver.outputs.selected, '3.12') }} == true || diff --git a/graphblas/tests/test_io.py b/graphblas/tests/test_io.py index bda41759b..05945cb6d 100644 --- a/graphblas/tests/test_io.py +++ b/graphblas/tests/test_io.py @@ -369,7 +369,7 @@ def test_scipy_sparse(): @pytest.mark.skipif("not ak") -@pytest.mark.xfail(reason="Need to investigate test failure") +# @pytest.mark.xfail(reason="Need to investigate test failure") def test_awkward_roundtrip(): # Vector v = gb.Vector.from_coo([1, 3, 5], [20, 21, -5], size=22) @@ -391,7 +391,7 @@ def test_awkward_roundtrip(): @pytest.mark.skipif("not ak") -@pytest.mark.xfail(reason="Need to investigate test failure") +# @pytest.mark.xfail(reason="Need to investigate test failure") def test_awkward_iso_roundtrip(): # Vector v = gb.Vector.from_coo([1, 3, 5], [20, 20, 20], size=22) From 3314e06678f179a03edb616d2126314d752dc35e Mon Sep 17 00:00:00 2001 From: Erik Welch Date: Thu, 22 Jun 2023 16:32:44 -0500 Subject: [PATCH 2/4] oops --- .github/workflows/test_and_build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test_and_build.yml b/.github/workflows/test_and_build.yml index b9bbede83..de3a7bd6e 100644 --- a/.github/workflows/test_and_build.yml +++ b/.github/workflows/test_and_build.yml @@ -228,7 +228,7 @@ jobs: numbaver=$(python -c 'import random ; print(random.choice(["=0.56", "=0.57", ""]))') fi fmm=fast_matrix_market${fmmver} - akver=${{ matrix.akver }} + akver="="${{ matrix.akver }} if [[ ${{ startsWith(steps.pyver.outputs.selected, '3.11') }} == true && ${awkward} == "awkward=1.9.0"]]; then akver="" fi From 9cf78501bd314545fac10c0e99475230515b378e Mon Sep 17 00:00:00 2001 From: Erik Welch Date: Thu, 22 Jun 2023 23:27:57 -0500 Subject: [PATCH 3/4] oops --- .github/workflows/test_and_build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test_and_build.yml b/.github/workflows/test_and_build.yml index de3a7bd6e..e3b7ecb9a 100644 --- a/.github/workflows/test_and_build.yml +++ b/.github/workflows/test_and_build.yml @@ -229,7 +229,7 @@ jobs: fi fmm=fast_matrix_market${fmmver} akver="="${{ matrix.akver }} - if [[ ${{ startsWith(steps.pyver.outputs.selected, '3.11') }} == true && ${awkward} == "awkward=1.9.0"]]; then + if [[ ${{ startsWith(steps.pyver.outputs.selected, '3.11') }} == true && ${awkward} == "awkward=1.9.0" ]] ; then akver="" fi awkward=awkward${akver} From 7f0591fb0d6518bf21168772542a4ecbba29be1e Mon Sep 17 00:00:00 2001 From: Erik Welch Date: Thu, 22 Jun 2023 23:34:49 -0500 Subject: [PATCH 4/4] oops again --- .github/workflows/test_and_build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test_and_build.yml b/.github/workflows/test_and_build.yml index e3b7ecb9a..ad7db8c46 100644 --- a/.github/workflows/test_and_build.yml +++ b/.github/workflows/test_and_build.yml @@ -229,7 +229,7 @@ jobs: fi fmm=fast_matrix_market${fmmver} akver="="${{ matrix.akver }} - if [[ ${{ startsWith(steps.pyver.outputs.selected, '3.11') }} == true && ${awkward} == "awkward=1.9.0" ]] ; then + if [[ ${{ startsWith(steps.pyver.outputs.selected, '3.11') }} == true && ${akver} == "=1.9.0" ]] ; then akver="" fi awkward=awkward${akver}