Don't use nox.session.create_tmp.

Julian · Julian · commit 4817d36a72d4 · 2023-07-09T15:18:22.000+02:00
It's basically a footgun, in that it:

    * doesn't create a pseudorandom temporary directory, it just gives you
      the path 'tmp/'
    * thereby then doesn't create separate directories if you call it multiple
      times
    * mutates the global (shell) environment state by setting TMPDIR to this
      'new' directory so other processes can now 'accidentally' end up
      sticking things in it

(In particular I was really confused how/why non-distribution files were being
plopped into my python -m build's outdir, but it was because TMPDIR was
sticking around)
diff --git a/noxfile.py b/noxfile.py
@@ -1,4 +1,5 @@
 from pathlib import Path
+from tempfile import TemporaryDirectory
 import os
 
 import nox
@@ -106,18 +107,11 @@ def audit(session, installable):
 
 @session(tags=["build"])
 def build(session):
-    session.install("build")
-    tmpdir = session.create_tmp()
-    session.run("python", "-m", "build", ROOT, "--outdir", tmpdir)
-
-
-@session(tags=["style"])
-def readme(session):
     session.install("build", "docutils", "twine")
-    tmpdir = session.create_tmp()
-    session.run("python", "-m", "build", ROOT, "--outdir", tmpdir)
-    session.run("python", "-m", "twine", "check", "--strict", tmpdir + "/*")
-    session.run("rst2html5.py", "--halt=warning", CHANGELOG, "/dev/null")
+    with TemporaryDirectory() as tmpdir:
+        session.run("python", "-m", "build", ROOT, "--outdir", tmpdir)
+        session.run("twine", "check", "--strict", tmpdir + "/*")
+        session.run("rst2html5.py", "--halt=warning", CHANGELOG, "/dev/null")
 
 
 @session()
@@ -154,20 +148,21 @@ def typing(session):
 )
 def docs(session, builder):
     session.install("-r", DOCS / "requirements.txt")
-    tmpdir = Path(session.create_tmp())
-    argv = ["-n", "-T", "-W"]
-    if builder != "spelling":
-        argv += ["-q"]
-    session.run(
-        "python",
-        "-m",
-        "sphinx",
-        "-b",
-        builder,
-        DOCS,
-        tmpdir / builder,
-        *argv,
-    )
+    with TemporaryDirectory() as tmpdir_str:
+        tmpdir = Path(tmpdir_str)
+        argv = ["-n", "-T", "-W"]
+        if builder != "spelling":
+            argv += ["-q"]
+        session.run(
+            "python",
+            "-m",
+            "sphinx",
+            "-b",
+            builder,
+            DOCS,
+            tmpdir / builder,
+            *argv,
+        )
 
 
 @session(tags=["docs", "style"], name="docs(style)")
