Deprecate jsonschema.RefResolver.in_scope.

Julian · Julian · commit 53820379c4e9 · 2021-08-25T11:02:25.000+01:00
It is unused in internal code and can be instead done via push/pop_scope
(at least until the entirety of RefResolver is deprecated).
diff --git a/jsonschema/tests/test_deprecations.py b/jsonschema/tests/test_deprecations.py
@@ -1,8 +1,10 @@
 from unittest import TestCase
 
+from jsonschema.validators import RefResolver
+
 
 class TestDeprecations(TestCase):
-    def test_jsonschema_version(self):
+    def test_version(self):
         """
         As of v4.0.0, __version__ is deprecated in favor of importlib.metadata.
         """
@@ -16,7 +18,7 @@ def test_jsonschema_version(self):
             ),
         )
 
-    def test_jsonschema_validators_ErrorTree(self):
+    def test_validators_ErrorTree(self):
         """
         As of v4.0.0, importing ErrorTree from jsonschema.validators is
         deprecated in favor of doing so from jsonschema.exceptions.
@@ -30,3 +32,19 @@ def test_jsonschema_validators_ErrorTree(self):
                 "Importing ErrorTree from jsonschema.validators is deprecated",
             ),
         )
+
+    def test_RefResolver_in_scope(self):
+        """
+        As of v4.0.0, RefResolver.in_scope is deprecated.
+        """
+
+        resolver = RefResolver.from_schema({})
+        with self.assertWarns(DeprecationWarning) as w:
+            with resolver.in_scope("foo"):
+                pass
+
+        self.assertTrue(
+            str(w.warning).startswith(
+                "jsonschema.RefResolver.in_scope is deprecated ",
+            ),
+        )
diff --git a/jsonschema/validators.py b/jsonschema/validators.py
@@ -691,6 +691,11 @@ def in_scope(self, scope):
         """
         Temporarily enter the given scope for the duration of the context.
         """
+        warnings.warn(
+            "jsonschema.RefResolver.in_scope is deprecated and will be "
+            "removed in a future release.",
+            DeprecationWarning,
+        )
         self.push_scope(scope)
         try:
             yield
