Add TP25 fixtures #729
Merged
Add TP25 fixtures #729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #729 +/- ##
=======================================
Coverage 87.99% 87.99%
=======================================
Files 41 41
Lines 3632 3632
Branches 910 910
=======================================
Hits 3196 3196
Misses 362 362
Partials 74 74 ☔ View full report in Codecov by Sentry. |
|
Looks like the tests pass, so we lack tests for this, too. Odd that it didn't crash with p300, needs a test and implementing setting |
This was referenced Jan 31, 2024
|
Please update the fixture after #733 gets merged. |
rytilahti
added a commit
to rytilahti/python-kasa
that referenced
this pull request
Feb 2, 2024
[Full Changelog](python-kasa/python-kasa@0.6.2...0.6.2.1) **Fixed bugs:** - Avoid crashing on childdevice property accesses [\python-kasa#732](python-kasa#732) (@rytilahti) **Merged pull requests:** - Retain last two chars for children device\_id [\python-kasa#733](python-kasa#733) (@rytilahti) - Add TP15 fixture [\python-kasa#730](python-kasa#730) (@bdraco) - Add TP25 fixtures [\python-kasa#729](python-kasa#729) (@bdraco) - Various test code cleanups [\python-kasa#725](python-kasa#725) (@rytilahti) - Unignore F401 for tests [\python-kasa#724](python-kasa#724) (@rytilahti)
Merged
rytilahti
added a commit
that referenced
this pull request
Feb 2, 2024
[Full Changelog](0.6.2...0.6.2.1) **Fixed bugs:** - Avoid crashing on childdevice property accesses [\#732](#732) (@rytilahti) **Merged pull requests:** - Retain last two chars for children device\_id [\#733](#733) (@rytilahti) - Add TP15 fixture [\#730](#730) (@bdraco) - Add TP25 fixtures [\#729](#729) (@bdraco) - Various test code cleanups [\#725](#725) (@rytilahti) - Unignore F401 for tests [\#724](#724) (@rytilahti)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this doesn't work in Hass yet