Lib: Avoid eval() for getting module-level variables

encukou · encukou · commit a06267f2cc9a · 2017-11-27T16:59:14.000+01:00
This is for compatibility with other libraries that inject extra variables, like unit testing with pytest. Based on a suggestion by AlanCoding: #25
diff --git a/Lib/ldap/schema/subentry.py b/Lib/ldap/schema/subentry.py
@@ -11,8 +11,7 @@
 SCHEMA_CLASS_MAPPING = ldap.cidict.cidict()
 SCHEMA_ATTR_MAPPING = {}
 
-for _name in dir():
-  o = eval(_name)
+for o in list(vars().values()):
   if hasattr(o,'schema_attribute'):
     SCHEMA_CLASS_MAPPING[o.schema_attribute] = o
     SCHEMA_ATTR_MAPPING[o] = o.schema_attribute
