Switch to loclist

klen · klen · commit cf8ddc70650a · 2013-12-02T21:04:39.000+07:00
diff --git a/autoload/pymode.vim b/autoload/pymode.vim
@@ -110,13 +110,17 @@ fun! pymode#buffer_pre_write() "{{{
 endfunction
 
 fun! pymode#buffer_post_write() "{{{
-    if b:pymode_modified && g:pymode_rope_regenerate_on_write
-        call pymode#debug('regenerate')
-        call pymode#rope#regenerate()
+    if g:pymode_rope
+        if b:pymode_modified && g:pymode_rope_regenerate_on_write
+            call pymode#debug('regenerate')
+            call pymode#rope#regenerate()
+        endif
     endif
-    if g:pymode_lint_unmodified || (g:pymode_lint_on_write && b:pymode_modified)
-        call pymode#debug('check code')
-        call pymode#lint#check()
+    if g:pymode_lint
+        if g:pymode_lint_unmodified || (g:pymode_lint_on_write && b:pymode_modified)
+            call pymode#debug('check code')
+            call pymode#lint#check()
+        endif
     endif
 endfunction "}}}
 
diff --git a/autoload/pymode/lint.vim b/autoload/pymode/lint.vim
@@ -65,8 +65,7 @@ fun! pymode#lint#check() "{{{
     call g:PymodeSigns.refresh(loclist)
 
     if g:pymode_lint_cwindow
-        call setqflist(loclist._loclist)
-        call pymode#quickfix_open(0, g:pymode_quickfix_maxheight, g:pymode_quickfix_minheight, 0)
+        call loclist.show()
     endif
 
     call pymode#lint#show_errormessage()
diff --git a/autoload/pymode/rope.vim b/autoload/pymode/rope.vim
@@ -2,6 +2,8 @@
 "
 PymodePython from pymode import rope
 
+call pymode#tools#loclist#init()
+
 
 fun! pymode#rope#completions(findstart, base)
     PymodePython rope.completions()
@@ -56,8 +58,10 @@ fun! pymode#rope#find_it()
     PymodePython rope.find_it()
     call pymode#wide_message('')
     if !empty(l:output)
-        call setqflist(l:output)
-        call pymode#quickfix_open(0, g:pymode_quickfix_maxheight, g:pymode_quickfix_minheight, 0)
+        let loclist = g:PymodeLocList.current()
+        let loclist._loclist = l:output
+        let loclist._title = "Occurrences"
+        call loclist.show()
     end
 endfunction
 
diff --git a/autoload/pymode/run.vim b/autoload/pymode/run.vim
@@ -43,6 +43,8 @@ let s:efm .= '%-G%.%#'
 
 PymodePython from pymode.run import run_code
 
+call pymode#tools#loclist#init()
+
 
 " DESC: Run python code
 fun! pymode#run#code_run(line1, line2) "{{{
@@ -86,7 +88,11 @@ fun! pymode#run#code_run(line1, line2) "{{{
             call setqflist(qflist)
         endif
 
-        call pymode#quickfix_open(0, g:pymode_quickfix_maxheight, g:pymode_quickfix_maxheight, 0)
+        let loclist = g:PymodeLocList.current()
+        let loclist._loclist = getqflist()
+        let loclist._title = "Run errors"
+        call loclist.show()
+
         let &efm = l:_efm
 
     catch /E234/
diff --git a/autoload/pymode/tools/loclist.vim b/autoload/pymode/tools/loclist.vim
@@ -10,6 +10,7 @@ fun! g:PymodeLocList.init(raw_list) "{{{
     let obj = copy(self)
     let loc_list = filter(copy(a:raw_list), 'v:val["valid"] == 1')
     call obj.clear()
+    let obj._title = 'CodeCheck'
     return obj
 endfunction "}}}
 
@@ -18,7 +19,6 @@ fun! g:PymodeLocList.current() "{{{
     if !exists("b:pymode_loclist")
         let b:pymode_loclist = g:PymodeLocList.init([])
     endif
-    let b:pymode_loclist._bufnr = bufnr('.')
     return b:pymode_loclist
 endfunction "}}}
 
@@ -31,7 +31,7 @@ endfunction "}}}
 fun! g:PymodeLocList.clear() "{{{
     let self._loclist = []
     let self._messages = {}
-    let self._bufnr = bufnr('')
+    let self._name = expand('%:t')
 endfunction "}}}
 
 
@@ -62,3 +62,19 @@ fun! g:PymodeLocList.filter(filters) "{{{
     endfor
     return loclist
 endfunction "}}}
+
+
+fun! g:PymodeLocList.show() "{{{
+    call setloclist(0, self._loclist)
+    if self.is_empty()
+        lclose
+    else
+        let num = winnr()
+        execute "lopen " . g:pymode_quickfix_maxheight
+        execute max([min([line("$"), g:pymode_quickfix_maxheight]), g:pymode_quickfix_minheight]) . "wincmd _"
+        if num != winnr()
+            call setwinvar(winnr(), 'quickfix_title', self._title . ' <' . self._name . '>')
+            wincmd p
+        endif
+    end
+endfunction "}}}
