bmk: add _PartBookmarkFinder._all_starts_and_ends

Benjamin Toornstra · scanny · commit a2df4462c7de · 2021-05-15T15:28:14.000-07:00
diff --git a/docx/bookmark.py b/docx/bookmark.py
@@ -85,7 +85,7 @@ def _all_starts_and_ends(self):
 
         Elements appear in document order.
         """
-        raise NotImplementedError
+        return self._part.element.xpath("//w:bookmarkStart|//w:bookmarkEnd")
 
     def _iter_starts(self):
         """Generate (idx, bookmarkStart) elements in story.
diff --git a/tests/test_bookmark.py b/tests/test_bookmark.py
@@ -124,6 +124,17 @@ def it_provides_an_iter_start_end_pairs_interface_method(
         _iter_start_end_pairs_.assert_called_once_with(ANY)
         assert pairs == _iter_start_end_pairs_.return_value
 
+    def it_gathers_all_the_bookmark_start_and_end_elements_to_help(self, part_):
+        body = element(
+            "w:body/(w:bookmarkStart,w:p,w:bookmarkEnd,w:p,w:bookmarkStart)"
+        )
+        part_.element = body
+        finder = _PartBookmarkFinder(part_)
+
+        starts_and_ends = finder._all_starts_and_ends
+
+        assert starts_and_ends == [body[0], body[2], body[4]]
+
     def it_iterates_start_end_pairs_to_help(
         self, _iter_starts_, _matching_end_, _name_already_used_
     ):
