bmk: Add _Bookmark.id

Benjamin Toornstra · scanny · commit c58ac35a4dfd · 2021-05-15T15:32:43.000-07:00
diff --git a/docx/bookmark.py b/docx/bookmark.py
@@ -57,7 +57,7 @@ def __init__(self, bookmark_pair):
     @property
     def id(self):
         """Provides access to the bookmark id."""
-        raise NotImplementedError
+        return self._bookmarkStart.id
 
     @property
     def name(self):
diff --git a/features/bmk-bookmarks.feature b/features/bmk-bookmarks.feature
@@ -10,7 +10,6 @@ Feature: Access a bookmark
       And bookmarks[1] is a _Bookmark object
       And iterating bookmarks produces 5 _Bookmark objects
 
-  @wip
   Scenario Outline: Bookmarks.get(bookmark_name)
     Given a Bookmarks object of length 5 as bookmarks
      Then bookmarks.get(<name>) returns bookmark named "<name>" with id <id>
diff --git a/tests/test_bookmark.py b/tests/test_bookmark.py
@@ -161,6 +161,14 @@ def _iter_(self, request):
 class Describe_Bookmark(object):
     """Unit-test suite for `docx.bookmark._Bookmark` object."""
 
+    def it_knows_its_id(self):
+        bookmarkStart = element("w:bookmarkStart{w:id=42}")
+        bookmarkEnd = element("w:bookmarkEnd")
+
+        bookmark = _Bookmark((bookmarkStart, bookmarkEnd))
+
+        assert bookmark.id == 42
+
     def it_knows_its_name(self):
         bookmarkStart = element("w:bookmarkStart{w:name=bmk-0}")
         bookmarkEnd = element("w:bookmarkEnd")
