Add umath funcs: maximum & minimum #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zm711
reviewed
Sep 30, 2024
| def test_maximum(self): | ||
| arr1 = (998, 999) * pq.m | ||
| arr2 = (1e3, 5e2) * pq.m | ||
| self.assertQuantityEqual(np.maximum(arr1, arr2) - [1000, 999]*pq.m, [0, 0]*pq.m) |
There was a problem hiding this comment.
Out of curiosity why do the subtraction and then compare to 0 rather than compare directly to the values? Is there a benefit to doing this in readability or reliability? :)
There was a problem hiding this comment.
Just a habit of mine, no particular reason.
There was a problem hiding this comment.
Cool. Just wanted to make sure I wasn't missing a trick. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that these were missing.