From 09a21b428f413fd68e3752bc7ff2104dd074dd61 Mon Sep 17 00:00:00 2001 From: Thomas Laferriere Date: Thu, 11 Jun 2020 08:23:23 -0400 Subject: [PATCH 1/4] Increase coverage in VersionInfo.compare --- test_semver.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test_semver.py b/test_semver.py index 1fd87ee6..ac70da8d 100644 --- a/test_semver.py +++ b/test_semver.py @@ -659,6 +659,8 @@ def test_should_not_allow_to_compare_version_with_int(): v1 > 1 with pytest.raises(TypeError): 1 > v1 + with pytest.raises(TypeError): + v1.compare(1) def test_should_compare_prerelease_with_numbers_and_letters(): From 3a3cd221593e8de0b704fd19ab82e9a1b15e0331 Mon Sep 17 00:00:00 2001 From: Thomas Laferriere Date: Thu, 11 Jun 2020 08:35:51 -0400 Subject: [PATCH 2/4] Test __repr__ --- test_semver.py | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/test_semver.py b/test_semver.py index ac70da8d..2a37f979 100644 --- a/test_semver.py +++ b/test_semver.py @@ -1076,3 +1076,35 @@ def test_next_version_with_versioninfo(version, part, expected): next_version = ver.next_version(part) assert isinstance(next_version, VersionInfo) assert str(next_version) == expected + +@pytest.mark.parametrize( + "version, expected", + [ + ( + VersionInfo(major=1, minor=2, patch=3, prerelease=None, build=None), + "VersionInfo(major=1, minor=2, patch=3, prerelease=None, build=None)" + ), + ( + VersionInfo(major=1, minor=2, patch=3, prerelease='r.1', build=None), + "VersionInfo(major=1, minor=2, patch=3, prerelease='r.1', build=None)" + ), + ( + VersionInfo(major=1, minor=2, patch=3, prerelease='dev.1', build=None), + "VersionInfo(major=1, minor=2, patch=3, prerelease='dev.1', build=None)" + ), + ( + VersionInfo(major=1, minor=2, patch=3, prerelease='dev.1', build='b.1'), + "VersionInfo(major=1, minor=2, patch=3, prerelease='dev.1', build='b.1')" + ), + ( + VersionInfo(major=1, minor=2, patch=3, prerelease='r.1', build='b.1'), + "VersionInfo(major=1, minor=2, patch=3, prerelease='r.1', build='b.1')" + ), + ( + VersionInfo(major=1, minor=2, patch=3, prerelease='r.1', build='build.1'), + "VersionInfo(major=1, minor=2, patch=3, prerelease='r.1', build='build.1')" + ), + ], +) +def test_repr(version, expected): + assert repr(version) == expected \ No newline at end of file From 60d73ed443e34bf79b1a58abff058ba18aaa779f Mon Sep 17 00:00:00 2001 From: Thomas Laferriere Date: Thu, 11 Jun 2020 09:01:30 -0400 Subject: [PATCH 3/4] Test nextver subcommand --- test_semver.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/test_semver.py b/test_semver.py index 2a37f979..03b2152d 100644 --- a/test_semver.py +++ b/test_semver.py @@ -24,7 +24,7 @@ parse, parse_version_info, process, - replace, + replace, cmd_nextver, ) SEMVERFUNCS = [ @@ -913,6 +913,10 @@ def test_should_parse_cli_arguments(cli, expected): # check subcommand (cmd_check, Namespace(version="1.2.3"), does_not_raise(None)), (cmd_check, Namespace(version="1.2"), pytest.raises(ValueError)), + # nextver subcommand + (cmd_nextver, Namespace(version="1.2.3", part="major"), does_not_raise("2.0.0")), + (cmd_nextver, Namespace(version="1.2", part="major"), pytest.raises(ValueError)), + (cmd_nextver, Namespace(version="1.2.3", part="nope"), pytest.raises(ValueError)), ], ) def test_should_process_parsed_cli_arguments(func, args, expectation): From a361d5a5a45b246485d6e3642a51144393a578bb Mon Sep 17 00:00:00 2001 From: Thomas Laferriere Date: Thu, 11 Jun 2020 09:03:42 -0400 Subject: [PATCH 4/4] Run black --- test_semver.py | 48 +++++++++++++++++++++++++++++++----------------- 1 file changed, 31 insertions(+), 17 deletions(-) diff --git a/test_semver.py b/test_semver.py index 03b2152d..015cb7d2 100644 --- a/test_semver.py +++ b/test_semver.py @@ -24,7 +24,8 @@ parse, parse_version_info, process, - replace, cmd_nextver, + replace, + cmd_nextver, ) SEMVERFUNCS = [ @@ -914,9 +915,21 @@ def test_should_parse_cli_arguments(cli, expected): (cmd_check, Namespace(version="1.2.3"), does_not_raise(None)), (cmd_check, Namespace(version="1.2"), pytest.raises(ValueError)), # nextver subcommand - (cmd_nextver, Namespace(version="1.2.3", part="major"), does_not_raise("2.0.0")), - (cmd_nextver, Namespace(version="1.2", part="major"), pytest.raises(ValueError)), - (cmd_nextver, Namespace(version="1.2.3", part="nope"), pytest.raises(ValueError)), + ( + cmd_nextver, + Namespace(version="1.2.3", part="major"), + does_not_raise("2.0.0"), + ), + ( + cmd_nextver, + Namespace(version="1.2", part="major"), + pytest.raises(ValueError), + ), + ( + cmd_nextver, + Namespace(version="1.2.3", part="nope"), + pytest.raises(ValueError), + ), ], ) def test_should_process_parsed_cli_arguments(func, args, expectation): @@ -1081,34 +1094,35 @@ def test_next_version_with_versioninfo(version, part, expected): assert isinstance(next_version, VersionInfo) assert str(next_version) == expected + @pytest.mark.parametrize( "version, expected", [ ( - VersionInfo(major=1, minor=2, patch=3, prerelease=None, build=None), - "VersionInfo(major=1, minor=2, patch=3, prerelease=None, build=None)" + VersionInfo(major=1, minor=2, patch=3, prerelease=None, build=None), + "VersionInfo(major=1, minor=2, patch=3, prerelease=None, build=None)", ), ( - VersionInfo(major=1, minor=2, patch=3, prerelease='r.1', build=None), - "VersionInfo(major=1, minor=2, patch=3, prerelease='r.1', build=None)" + VersionInfo(major=1, minor=2, patch=3, prerelease="r.1", build=None), + "VersionInfo(major=1, minor=2, patch=3, prerelease='r.1', build=None)", ), ( - VersionInfo(major=1, minor=2, patch=3, prerelease='dev.1', build=None), - "VersionInfo(major=1, minor=2, patch=3, prerelease='dev.1', build=None)" + VersionInfo(major=1, minor=2, patch=3, prerelease="dev.1", build=None), + "VersionInfo(major=1, minor=2, patch=3, prerelease='dev.1', build=None)", ), ( - VersionInfo(major=1, minor=2, patch=3, prerelease='dev.1', build='b.1'), - "VersionInfo(major=1, minor=2, patch=3, prerelease='dev.1', build='b.1')" + VersionInfo(major=1, minor=2, patch=3, prerelease="dev.1", build="b.1"), + "VersionInfo(major=1, minor=2, patch=3, prerelease='dev.1', build='b.1')", ), ( - VersionInfo(major=1, minor=2, patch=3, prerelease='r.1', build='b.1'), - "VersionInfo(major=1, minor=2, patch=3, prerelease='r.1', build='b.1')" + VersionInfo(major=1, minor=2, patch=3, prerelease="r.1", build="b.1"), + "VersionInfo(major=1, minor=2, patch=3, prerelease='r.1', build='b.1')", ), ( - VersionInfo(major=1, minor=2, patch=3, prerelease='r.1', build='build.1'), - "VersionInfo(major=1, minor=2, patch=3, prerelease='r.1', build='build.1')" + VersionInfo(major=1, minor=2, patch=3, prerelease="r.1", build="build.1"), + "VersionInfo(major=1, minor=2, patch=3, prerelease='r.1', build='build.1')", ), ], ) def test_repr(version, expected): - assert repr(version) == expected \ No newline at end of file + assert repr(version) == expected