Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.91%. Comparing base (d216c96) to head (b243d44).
Report is 40 commits behind head on master.

@@            Coverage Diff             @@
##           master     #950      +/-   ##
==========================================
+ Coverage   77.77%   77.91%   +0.13%     
==========================================
  Files         347      347              
  Lines       10606    10673      +67     
  Branches      699      503     -196     
==========================================
+ Hits         8249     8316      +67     
+ Misses       2200     2198       -2     
- Partials      157      159       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The failing tests are affected by gabrielfalcao/HTTPretty#484, but as they pass on 3.8 I assume this is safe to merge.

@nijel I would like to suggest to release such changes as major version bumps. I understand that this change is needed for new apps to work. However, this change also killed OAuth with our old linkedin app. Is there any information available, how to transition old apps to this new flow? What settings have to be adjusted? This is our config that now breaks all caused by a patch version bump which IMO is utterly wrong. M$ so far has not forced us to do anything.

SOCIAL_AUTH_LINKEDIN_OAUTH2_SCOPE = ['r_liteprofile', 'r_emailaddress']
SOCIAL_AUTH_LINKEDIN_OAUTH2_FIELD_SELECTORS = ['emailAddress', 'profilePicture(displayImage~:playableStreams)']

SOCIAL_AUTH_LINKEDIN_OAUTH2_EXTRA_DATA = [
    ('id', 'id'),
    ('firstName', 'first_name'),
    ('lastName', 'last_name'),
    ('emailAddress', 'email_address'),
    ('profilePicture', 'profile_picture'),
]

Sorry, I didn't realize that this would be a breaking change, I considered it a fix for an API change. Unfortunately I have no knowledge of LinkedIn APIs....