Convenience Functionality for BusinessOpeningHours #4861
Conversation
-check if the business is open at a given time -get the opening hours for a given day
Convenience Functionality for BusinessOpeningHours -check if the business is open at a given time -get the opening hours for a given day
There was a problem hiding this comment.
Hey. Thanks for your PR!
I gave it first quick look, but without actually reviewing the new logic. For starters, I focused on a few formalities and setup problems since you're apprantly strugging with this #4194 (comment). I hope that my comments help you.
Please also make sure to check the output of the pre-commit ci run in the "status checks" tab on the PR.
Please let me know if you need additional help with getting the tests running & pre-commit to pass - or when that's done and I should review properly :) Looking forward to it!
| try: | ||
| return zoneinfo.ZoneInfo(tz) | ||
| except zoneinfo.ZoneInfoNotFoundError as err: | ||
| raise TelegramError( |
There was a problem hiding this comment.
| raise TelegramError( | |
| raise oneinfo.ZoneInfoNotFoundError( |
src/telegram/_utils/enum.py
Outdated
There was a problem hiding this comment.
please revert. This is unrelated to your changes and in fact the pre-commit ci run complains about it
Co-authored-by: Bibo-Joshi <[email protected]>
Co-authored-by: Bibo-Joshi <[email protected]>
Co-authored-by: Bibo-Joshi <[email protected]>
Co-authored-by: Bibo-Joshi <[email protected]>
|
Hello. Im having general problems to understand work flow here in git PR ) Please guide me) |
|
Hi I am going to give this a shot.
I do not quite get the question here, which requested changed did you not apply successfully? Yes the git actions will run on every commit. Doesn't really matter, the important part is that they don't fail on the last one.
The pre commit CI is imo pretty self explanatory, you apparently in the second PR also already fixed some issues there, so I am going to assume you understand that. You can also change the branch in this PR to your new one in your repo. We can ignore the Bot API test, and fix the chango/security analysis later. The important part to ensure you code is working correctly is the pre commit and the unit test. If you open any unit test run, and wait for it to load, you should have a huge wall of text. Scroll up to leave the flaky tests behind, until you see tests/test_business_classes.py:715: AssertionError. These are now the unit tests which failed, and they explain you where it failed and why (what it expected, what it got). You need to scroll up further to see them all, but you will get quickly an idea what the output format is. So either you need to fix the tests, or your code. Do that for all the tests, and see where that gets you. If you have more questions, make sure you read through the contrib guidelines and otherwise ask. Just here, or in our development group. |
|
On my pc i have this (python-telegram-bot) PS C:\Users\Aweryc\PycharmProjects\python-telegram-bot> pre-commit run -a Now go to CI steps) |
Convenience Functionality for BusinessOpeningHours
-check if the business is open at a given time
-get the opening hours for a given day