Thanks to visit codestin.com
Credit goes to github.com

Skip to content

mypy fails at _version.py #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
headtr1ck opened this issue Oct 5, 2021 · 1 comment
Closed

mypy fails at _version.py #268

headtr1ck opened this issue Oct 5, 2021 · 1 comment

Comments

@headtr1ck
Copy link
Contributor

After installing versioneer v0.20 in our project mypy fails with:

package/_version.py:54: error: Need type annotation for "LONG_VERSION_PY" (hint: "LONG_VERSION_PY: Dict[<type>, <type>] = ...")

I know that one could simply ignore this file in the mypy config, but since it is only this single complaint you could maybe add the type hint? If I see it correctly it is simply:

LONG_VERSION_PY: dict[str, str] = {}
@effigies
Copy link
Contributor

effigies commented Oct 5, 2021

I think that's correct, and I'm fine with it if it doesn't break Python 3.6. Care to make a PR?

@headtr1ck headtr1ck mentioned this issue Oct 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@effigies @headtr1ck