* Why does pystring.cs claim to be ansi, then call PyUnicode_FromUnicode() in the string contructor?

Barton Cline · Barton Cline · commit 0b066e8a348d · 2011-01-30T09:45:18.000Z
* pyansistring.cs added it to the Python.Runtime namespace
diff --git a/pythonnet/src/runtime/pyansistring.cs b/pythonnet/src/runtime/pyansistring.cs
@@ -1,63 +1,82 @@
-public class PyAnsiString : PySequence {
-	/// <summary>
-	/// PyAnsiString Constructor
-	/// </summary>
-	///
-	/// <remarks>
-	/// Creates a new PyAnsiString from an existing object reference. Note
-	/// that the instance assumes ownership of the object reference.
-	/// The object reference is not checked for type-correctness.
-	/// </remarks>
-
-	public PyAnsiString(IntPtr ptr) : base(ptr) { }
-
-
-	/// <summary>
-	/// PyString Constructor
-	/// </summary>
-	///
-	/// <remarks>
-	/// Copy constructor - obtain a PyAnsiString from a generic PyObject.
-	/// An ArgumentException will be thrown if the given object is not
-	/// a Python string object.
-	/// </remarks>
-
-	public PyAnsiString(PyObject o)
-		: base() {
-		if (!IsStringType(o)) {
-			throw new ArgumentException("object is not a string");
-		}
-		Runtime.Incref(o.obj);
-		obj = o.obj;
-	}
-
-
-	/// <summary>
-	/// PyAnsiString Constructor
-	/// </summary>
-	///
-	/// <remarks>
-	/// Creates a Python string from a managed string.
-	/// </remarks>
-
-	public PyAnsiString(string s)
-		: base() {
-		obj = Runtime.PyString_FromStringAndSize(s, s.Length);
-		if (obj == IntPtr.Zero) {
-			throw new PythonException();
-		}
-	}
-
-
-	/// <summary>
-	/// IsStringType Method
-	/// </summary>
-	///
-	/// <remarks>
-	/// Returns true if the given object is a Python string.
-	/// </remarks>
-
-	public static bool IsStringType(PyObject value) {
-		return Runtime.PyString_Check(value.obj);
-	}
+// ==========================================================================
+// This is a user contribution to the pythondotnet project.
+// THIS SOFTWARE IS PROVIDED "AS IS" AND ANY AND ALL EXPRESS OR IMPLIED
+// WARRANTIES ARE DISCLAIMED, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+// WARRANTIES OF TITLE, MERCHANTABILITY, AGAINST INFRINGEMENT, AND FITNESS
+// FOR A PARTICULAR PURPOSE.
+// ==========================================================================
+
+using System;
+
+namespace Python.Runtime {
+
+    public class PyAnsiString : PySequence
+    {
+        /// <summary>
+        /// PyAnsiString Constructor
+        /// </summary>
+        ///
+        /// <remarks>
+        /// Creates a new PyAnsiString from an existing object reference. Note
+        /// that the instance assumes ownership of the object reference.
+        /// The object reference is not checked for type-correctness.
+        /// </remarks>
+
+        public PyAnsiString(IntPtr ptr) : base(ptr) { }
+
+
+        /// <summary>
+        /// PyString Constructor
+        /// </summary>
+        ///
+        /// <remarks>
+        /// Copy constructor - obtain a PyAnsiString from a generic PyObject.
+        /// An ArgumentException will be thrown if the given object is not
+        /// a Python string object.
+        /// </remarks>
+
+        public PyAnsiString(PyObject o)
+            : base()
+        {
+            if (!IsStringType(o))
+            {
+                throw new ArgumentException("object is not a string");
+            }
+            Runtime.Incref(o.obj);
+            obj = o.obj;
+        }
+
+
+        /// <summary>
+        /// PyAnsiString Constructor
+        /// </summary>
+        ///
+        /// <remarks>
+        /// Creates a Python string from a managed string.
+        /// </remarks>
+
+        public PyAnsiString(string s)
+            : base()
+        {
+            obj = Runtime.PyString_FromStringAndSize(s, s.Length);
+            if (obj == IntPtr.Zero)
+            {
+                throw new PythonException();
+            }
+        }
+
+
+        /// <summary>
+        /// IsStringType Method
+        /// </summary>
+        ///
+        /// <remarks>
+        /// Returns true if the given object is a Python string.
+        /// </remarks>
+
+        public static bool IsStringType(PyObject value)
+        {
+            return Runtime.PyString_Check(value.obj);
+        }
+    }
 }
diff --git a/pythonnet/src/runtime/pystring.cs b/pythonnet/src/runtime/pystring.cs
@@ -14,6 +14,7 @@ namespace Python.Runtime {
     /// <summary>
     /// Represents a Python (ansi) string object. See the documentation at
     /// http://www.python.org/doc/current/api/stringObjects.html for details.
+    /// 2011-01-29: ...Then why does the string constructor call PyUnicode_FromUnicode()???
     /// </summary>
 
     public class PyString : PySequence {
