* With Advanced Build Settings::Check for arithmetic overflow/underflow set, this is the only section that threw while running unittest.

Barton Cline · Barton Cline · commit 18c7e9a9ffad · 2011-01-10T04:08:42.000Z
diff --git a/pythonnet/src/runtime/converter.cs b/pythonnet/src/runtime/converter.cs
@@ -450,9 +450,14 @@ static bool ToPrimitive(IntPtr value, Type obType, out Object result,
                     if (Runtime.PyUnicode_GetSize(value) == 1) {
                         op = Runtime.PyUnicode_AS_UNICODE(value);
 #if (!UCS4)
-                        result = (char)Marshal.ReadInt16(op);
+                        // 2011-01-02: Marshal as character array because the cast
+                        // result = (char)Marshal.ReadInt16(op); throws an OverflowException
+                        // on negative numbers with Check Overflow option set on the project
+                        Char[] buff = new Char[1];
+                        Marshal.Copy(op, buff, 0, 1);
+                        result = buff[0];
 #else
-                        // XXX is this correct?
+                        // XXX this is probably NOT correct?
                         result = (char)Marshal.ReadInt32(op);
 #endif
                         return true;
