fixed conversion to array crashing when sequence object does not implement PySequence_Size

lostmsu · lostmsu · commit 1bc7dc4affa6 · 2020-02-26T21:04:04.000-08:00
diff --git a/src/runtime/converter.cs b/src/runtime/converter.cs
@@ -884,7 +884,22 @@ private static bool ToArray(IntPtr value, Type obType, out object result, bool s
             result = null;
 
             bool IsSeqObj = Runtime.PySequence_Check(value);
-            var len = IsSeqObj ? Runtime.PySequence_Size(value) : -1;
+            int len = -1;
+            if (IsSeqObj)
+            {
+                long longLen = Runtime.PySequence_Size(value);
+                if (longLen > int.MaxValue)
+                {
+                    if (setError)
+                    {
+                        Exceptions.SetError(Exceptions.NotImplementedError, ".NET does not support lists with over 2^31 elements");
+                    }
+
+                    return false;
+                }
+
+                len = longLen < 0 ? -1 : checked((int)longLen);
+            }
 
             IntPtr IterObject = Runtime.PyObject_GetIter(value);
 
@@ -900,7 +915,7 @@ private static bool ToArray(IntPtr value, Type obType, out object result, bool s
 
             var listType = typeof(List<>);
             var constructedListType = listType.MakeGenericType(elementType);
-            IList list = IsSeqObj ? (IList) Activator.CreateInstance(constructedListType, new Object[] {(int) len}) : 
+            IList list = len > 0 ? (IList) Activator.CreateInstance(constructedListType, new Object[] {len}) : 
                                         (IList) Activator.CreateInstance(constructedListType);
             IntPtr item;
 
