Merge branch 'master' into master

filmor · web-flow · commit 55171b9f793d · 2018-10-16T11:30:44.000+02:00
diff --git a/AUTHORS.md b/AUTHORS.md
@@ -26,6 +26,7 @@
 -   Dmitriy Se ([@dmitriyse](https://github.com/dmitriyse))
 -   He-chien Tsai ([@t3476](https://github.com/t3476))
 -   Ivan Cronyn ([@cronan](https://github.com/cronan))
+-   Jan Krivanek ([@jakrivan](https://github.com/jakrivan))
 -   Jeff Reback ([@jreback](https://github.com/jreback))
 -   Joe Frayne ([@jfrayne](https://github.com/jfrayne))
 -   John Burnett ([@johnburnett](https://github.com/johnburnett))
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -19,6 +19,7 @@ This document follows the conventions laid out in [Keep a CHANGELOG][].
 -   Catches exceptions thrown in C# iterators (yield returns) and rethrows them in python ([#475][i475])([#693][p693])
 -   Implemented GetDynamicMemberNames() for PyObject to allow dynamic object members to be visible in the debugger ([#443][i443])([#690][p690])
 -   Incorporated reference-style links to issues and pull requests in the CHANGELOG ([#608][i608])
+-   Added detailed comments about aproaches and dangers to handle multi-app-domains ([#625][p625])
 
 ### Changed
 
@@ -683,4 +684,5 @@ This document follows the conventions laid out in [Keep a CHANGELOG][].
 [p225]: https://github.com/pythonnet/pythonnet/pull/225
 [p78]: https://github.com/pythonnet/pythonnet/pull/78
 [p163]: https://github.com/pythonnet/pythonnet/pull/163
+[p625]: https://github.com/pythonnet/pythonnet/pull/625
 [i131]: https://github.com/pythonnet/pythonnet/issues/131
diff --git a/appveyor.yml b/appveyor.yml
@@ -28,6 +28,12 @@ environment:
     - PYTHON_VERSION: 3.5
     - PYTHON_VERSION: 3.6
 
+matrix:
+    allow_failures:
+      - PYTHON_VERSION: 3.4
+        BUILD_OPTS: --xplat
+      - PYTHON_VERSION: 3.4
+
 init:
   # Update Environment Variables based on matrix/platform
   - set PY_VER=%PYTHON_VERSION:.=%
diff --git a/setup.py b/setup.py
@@ -344,7 +344,7 @@ def _install_packages(self):
             self.debug_print("Updating NuGet: {0}".format(cmd))
             subprocess.check_call(cmd, shell=use_shell)
 
-            cmd = "{0} restore pythonnet.sln -o packages".format(nuget)
+            cmd = "{0} restore pythonnet.sln  -MSBuildVersion 14 -o packages".format(nuget)
             self.debug_print("Installing packages: {0}".format(cmd))
             subprocess.check_call(cmd, shell=use_shell)
 
diff --git a/src/runtime/assemblymanager.cs b/src/runtime/assemblymanager.cs
@@ -17,7 +17,15 @@ internal class AssemblyManager
     {
         // modified from event handlers below, potentially triggered from different .NET threads
         // therefore this should be a ConcurrentDictionary
+        //
+        // WARNING: Dangerous if cross-app domain usage is ever supported
+        //    Reusing the dictionary with assemblies accross multiple initializations is problematic. 
+        //    Loading happens from CurrentDomain (see line 53). And if the first call is from AppDomain that is later unloaded, 
+        //    than it can end up referring to assemblies that are already unloaded (default behavior after unload appDomain - 
+        //     unless LoaderOptimization.MultiDomain is used);
+        //    So for multidomain support it is better to have the dict. recreated for each app-domain initialization
         private static ConcurrentDictionary<string, ConcurrentDictionary<Assembly, string>> namespaces;
+
         //private static Dictionary<string, Dictionary<string, string>> generics;
         private static AssemblyLoadEventHandler lhandler;
         private static ResolveEventHandler rhandler;
diff --git a/src/runtime/runtime.cs b/src/runtime/runtime.cs
@@ -1190,7 +1190,11 @@ internal static bool PyString_Check(IntPtr ob)
 
         internal static IntPtr PyString_FromString(string value)
         {
+#if PYTHON3
+            return PyUnicode_FromKindAndData(_UCS, value, value.Length);
+#elif PYTHON2
             return PyString_FromStringAndSize(value, value.Length);
+#endif
         }
 
 #if PYTHON3
@@ -1205,13 +1209,6 @@ internal static IntPtr PyBytes_AS_STRING(IntPtr ob)
             return ob + BytesOffset.ob_sval;
         }
 
-        [DllImport(_PythonDll, CallingConvention = CallingConvention.Cdecl,
-            EntryPoint = "PyUnicode_FromStringAndSize")]
-        internal static extern IntPtr PyString_FromStringAndSize(
-            [MarshalAs(UnmanagedType.CustomMarshaler, MarshalTypeRef = typeof(Utf8Marshaler))] string value,
-            int size
-        );
-
         [DllImport(_PythonDll, CallingConvention = CallingConvention.Cdecl)]
         internal static extern IntPtr PyUnicode_FromStringAndSize(IntPtr value, int size);
 #elif PYTHON2
diff --git a/src/testing/conversiontest.cs b/src/testing/conversiontest.cs
@@ -60,4 +60,19 @@ public string GetValue()
             return value;
         }
     }
+    
+    public class UnicodeString
+    {
+        public string value = "안녕";
+
+        public string GetString()
+        {
+            return value;
+        }
+
+        public override string ToString()
+        {
+            return value;
+        }
+    }
 }
diff --git a/src/tests/test_conversion.py b/src/tests/test_conversion.py
@@ -2,11 +2,12 @@
 
 """Test CLR <-> Python type conversions."""
 
+from __future__ import unicode_literals
 import System
 import pytest
-from Python.Test import ConversionTest
+from Python.Test import ConversionTest, UnicodeString
 
-from ._compat import indexbytes, long, unichr
+from ._compat import indexbytes, long, unichr, text_type, PY2, PY3
 
 
 def test_bool_conversion():
@@ -535,6 +536,14 @@ def test_string_conversion():
 
     with pytest.raises(TypeError):
         ConversionTest().StringField = 1
+    
+    world = UnicodeString()
+    test_unicode_str = u"안녕"
+    assert test_unicode_str == text_type(world.value)
+    assert test_unicode_str == text_type(world.GetString())
+    # TODO: not sure what to do for Python 2 here (GH PR #670)
+    if PY3:
+        assert test_unicode_str == text_type(world)
 
 
 def test_interface_conversion():
