SetPythonPath attempts to import many modules

tminka · tminka · commit 60288a0baec4 · 2021-01-03T20:43:27.000Z
diff --git a/src/embed_tests/TestPythonEngineProperties.cs b/src/embed_tests/TestPythonEngineProperties.cs
@@ -1,8 +1,10 @@
 using System;
+using System.Collections.Generic;
 using System.IO;
 using System.Linq;
 
 using NUnit.Framework;
+
 using Python.Runtime;
 
 namespace Python.EmbeddingTest
@@ -183,7 +185,19 @@ public void SetProgramName()
         [Test]
         public void SetPythonPath()
         {
-            const string moduleName = "pytest";
+            string[] moduleNames = new string[] {
+                "iniconfig",
+                "urllib3",
+                "pytest",
+                "toml",
+                "idna",
+                "chardet",
+                "pyparsing",
+                "wheel",
+                "setuptools",
+                "pycparser",
+                "psutil"
+            };
             string path;
 
             using (Py.GIL())
@@ -196,21 +210,9 @@ public void SetPythonPath()
                 // After PythonPath is set, then PythonEngine.PythonPath will correctly return the full search path. 
 
                 string[] paths = Py.Import("sys").GetAttr("path").As<string[]>();
-                path = string.Join(System.IO.Path.PathSeparator.ToString(), paths);
-
-                try
-                {
-                    Py.Import(moduleName);
-                }
-                catch (PythonException ex)
-                {
-                    string[] messages = paths.Where(p => p.Contains("site-packages")).Select(folder =>
-                        (folder != null && Directory.Exists(folder)) ?
-                        $" {folder} contains {string.Join(Path.PathSeparator.ToString(), Directory.EnumerateFileSystemEntries(folder).Select(fullName => Path.GetFileName(fullName)).ToArray())}" :
-                        "").ToArray();
-                    string message = string.Join(" ", messages);
-                    throw new Exception($"Py.Import(\"{moduleName}\") failed before setting PythonEngine.PythonPath.  sys.path={path}{message}", ex);
-                }
+                path = string.Join(Path.PathSeparator.ToString(), paths);
+
+                TryToImport(moduleNames, "before setting PythonPath");
             }
 
             PythonEngine.PythonPath = path;
@@ -219,15 +221,40 @@ public void SetPythonPath()
             {
 
                 Assert.AreEqual(path, PythonEngine.PythonPath);
-                // Check that the module remains loadable
-                try
-                {
-                    Py.Import(moduleName);
-                }
-                catch (PythonException ex)
-                {
-                    throw new Exception($"Py.Import(\"{moduleName}\") failed after setting PythonEngine.PythonPath to {path}", ex);
-                }
+                // Check that the modules remain loadable
+                TryToImport(moduleNames, "after setting PythonEngine.PythonPath");
+            }
+        }
+
+        void TryToImport(IEnumerable<string> moduleNames, string message)
+        {
+            List<Exception> exceptions = new List<Exception>();
+            foreach (var moduleName in moduleNames)
+            {
+                var exception = TryToImport(moduleName, " before setting PythonPath");
+                if (exception != null) exceptions.Add(exception);
+            }
+            if (exceptions.Count > 0)
+                throw new AggregateException(exceptions);
+        }
+
+        Exception TryToImport(string moduleName, string message)
+        {
+            try
+            {
+                Py.Import(moduleName);
+                return null;
+            }
+            catch (PythonException ex)
+            {
+                string[] paths = Py.Import("sys").GetAttr("path").As<string[]>();
+                string path = string.Join(Path.PathSeparator.ToString(), paths);
+                string[] messages = paths.Where(p => p.Contains("site-packages")).Select(folder =>
+                    (folder != null && Directory.Exists(folder)) ?
+                    $" {folder} contains {string.Join(Path.PathSeparator.ToString(), Directory.EnumerateFileSystemEntries(folder).Select(fullName => Path.GetFileName(fullName)).ToArray())}" :
+                    "").ToArray();
+                string folderContents = string.Join(" ", messages);
+                return new Exception($"Py.Import(\"{moduleName}\") failed {message}, sys.path={path}{folderContents}", ex);
             }
         }
     }
