Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 74d87c5

Browse files
committed
simplified outdated condition in ClassBase.tp_clear
1 parent d5f1c48 commit 74d87c5

1 file changed

Lines changed: 8 additions & 12 deletions

File tree

src/runtime/classbase.cs

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -341,9 +341,9 @@ public static void tp_dealloc(NewReference lastRef)
341341

342342
tp_clear(lastRef.Borrow());
343343

344-
IntPtr addr = lastRef.DangerousGetAddress();
345-
bool deleted = CLRObject.reflectedObjects.Remove(addr);
346-
Debug.Assert(deleted);
344+
IntPtr addr = lastRef.DangerousGetAddress();
345+
bool deleted = CLRObject.reflectedObjects.Remove(addr);
346+
Debug.Assert(deleted);
347347

348348
Runtime.PyObject_GC_UnTrack(lastRef.Borrow());
349349
Runtime.PyObject_GC_Del(lastRef.Steal());
@@ -353,17 +353,13 @@ public static void tp_dealloc(NewReference lastRef)
353353

354354
public static int tp_clear(BorrowedReference ob)
355355
{
356-
bool isTypeObject = Runtime.PyObject_TYPE(ob) == Runtime.PyCLRMetaType;
357-
if (!isTypeObject)
356+
int baseClearResult = BaseUnmanagedClear(ob);
357+
if (baseClearResult != 0)
358358
{
359-
int baseClearResult = BaseUnmanagedClear(ob);
360-
if (baseClearResult != 0)
361-
{
362-
return baseClearResult;
363-
}
364-
365-
ClearObjectDict(ob);
359+
return baseClearResult;
366360
}
361+
362+
ClearObjectDict(ob);
367363
return 0;
368364
}
369365

0 commit comments

Comments
 (0)