increfs in OnSave are no longer necessary with the new references

lostmsu · lostmsu · commit a1427ac34616 · 2021-10-19T17:47:44.000-07:00
diff --git a/src/runtime/clrobject.cs b/src/runtime/clrobject.cs
@@ -77,12 +77,6 @@ internal static CLRObject Restore(object ob, BorrowedReference pyHandle, InterDo
             return co;
         }
 
-        protected override void OnSave(InterDomainContext context)
-        {
-            base.OnSave(context);
-            Runtime.XIncref(pyHandle);
-        }
-
         protected override void OnLoad(InterDomainContext context)
         {
             base.OnLoad(context);
diff --git a/src/runtime/methodobject.cs b/src/runtime/methodobject.cs
@@ -213,15 +213,5 @@ protected override void Clear(BorrowedReference ob)
             ClearObjectDict(this.pyHandle);
             base.Clear(ob);
         }
-
-        protected override void OnSave(InterDomainContext context)
-        {
-            base.OnSave(context);
-            if (unbound != null)
-            {
-                Runtime.XIncref(unbound.pyHandle);
-            }
-            Runtime.XIncref(doc);
-        }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -77,12 +77,6 @@ internal static CLRObject Restore(object ob, BorrowedReference pyHandle, InterDo`
`77`	`77`	`return co;`
`78`	`78`	`}`
`79`	`79`
`80`		`- protected override void OnSave(InterDomainContext context)`
`81`		`- {`
`82`		`- base.OnSave(context);`
`83`		`- Runtime.XIncref(pyHandle);`
`84`		`- }`
`85`		`-`
`86`	`80`	`protected override void OnLoad(InterDomainContext context)`
`87`	`81`	`{`
`88`	`82`	`base.OnLoad(context);`
Original file line number	Diff line number	Diff line change
`@@ -213,15 +213,5 @@ protected override void Clear(BorrowedReference ob)`
`213`	`213`	`ClearObjectDict(this.pyHandle);`
`214`	`214`	`base.Clear(ob);`
`215`	`215`	`}`
`216`		`-`
`217`		`- protected override void OnSave(InterDomainContext context)`
`218`		`- {`
`219`		`- base.OnSave(context);`
`220`		`- if (unbound != null)`
`221`		`- {`
`222`		`- Runtime.XIncref(unbound.pyHandle);`
`223`		`- }`
`224`		`- Runtime.XIncref(doc);`
`225`		`- }`
`226`	`216`	`}`
`227`	`217`	`}`