when converting to object, wrap values of unknown type into PyObject instead of failing

lostmsu · lostmsu · commit ad360311c05e · 2020-02-26T21:04:04.000-08:00
This enables overload resolution with object parameters to behave the same way PyObject parameters behave - e.g. allow any Python object to be passed as PyObject as fallback. Resolves #811
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -58,6 +58,7 @@ This document follows the conventions laid out in [Keep a CHANGELOG][].
 -   Reattach python exception traceback information (#545)
 -   PythonEngine.Intialize will now call `Py_InitializeEx` with a default value of 0, so signals will not be configured by default on embedding. This is different from the previous behaviour, where `Py_Initialize` was called instead, which sets initSigs to 1. ([#449][i449])
 -   Refactored MethodBinder.Bind in preparation to make it extensible (#829)
+-   When calling C# from Python, enable passing argument of any type to a parameter of C# type `object` by wrapping it into `PyObject` instance. ([#881][i881])
 -   Look for installed Windows 10 sdk's during installation instead of relying on specific versions.
 
 ### Fixed
diff --git a/src/runtime/converter.cs b/src/runtime/converter.cs
@@ -398,12 +398,9 @@ internal static bool ToManagedValue(IntPtr value, Type obType,
                     return ToArray(value, typeof(object[]), out result, setError);
                 }
 
-                if (setError)
-                {
-                    Exceptions.SetError(Exceptions.TypeError, "value cannot be converted to Object");
-                }
-
-                return false;
+                Runtime.XIncref(value); // PyObject() assumes ownership
+                result = new PyObject(value);
+                return true;
             }
 
             // Conversion to 'Type' is done using the same mappings as above for objects.

Original file line number	Diff line number	Diff line change
`@@ -398,12 +398,9 @@ internal static bool ToManagedValue(IntPtr value, Type obType,`
`398`	`398`	`return ToArray(value, typeof(object[]), out result, setError);`
`399`	`399`	`}`
`400`	`400`
`401`		`- if (setError)`
`402`		`- {`
`403`		`- Exceptions.SetError(Exceptions.TypeError, "value cannot be converted to Object");`
`404`		`- }`
`405`		`-`
`406`		`- return false;`
	`401`	`+ Runtime.XIncref(value); // PyObject() assumes ownership`
	`402`	`+ result = new PyObject(value);`
	`403`	`+ return true;`
`407`	`404`	`}`
`408`	`405`
`409`	`406`	`// Conversion to 'Type' is done using the same mappings as above for objects.`