Thanks to visit codestin.com
Credit goes to github.com

Skip to content

TryComputeClrArgumentType doesn't do anything #2474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
twastvedt opened this issue Oct 4, 2024 · 3 comments
Open

TryComputeClrArgumentType doesn't do anything #2474

twastvedt opened this issue Oct 4, 2024 · 3 comments

Comments

@twastvedt
Copy link

pythonnet/src/runtime/MethodBinder.cs

Lines 691 to 693 in de7a1d2

Type? clrtype = null;
if (clrtype != null)

Was stepping through the code trying to debug something (I think) unrelated, and noticed that TryComputeClrArgumentType always skips its contents. Is that intended?
@lostmsu
Copy link
Member

lostmsu commented Oct 4, 2024

It may be dead code, but most certainly is not intended.

@twastvedt twastvedt changed the title TryComputeClrArgumentType doesn't do anything. Intended? TryComputeClrArgumentType doesn't do anything Oct 7, 2024
@filmor
Copy link
Member

filmor commented Oct 27, 2024

@lostmsu This is the relevant PR: #1531, a fix for #1523

It has been like this for all v3 releases.

@lostmsu
Copy link
Member

lostmsu commented Oct 28, 2024

@filmor and we've got no major complains about parameter type resolution. I think it can be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@filmor @lostmsu @twastvedt