From 0f0362458ad2f6e7069af79b377e4308a00e111b Mon Sep 17 00:00:00 2001
From: Victor Milovanov <lost@losttech.software>
Date: Tue, 10 Mar 2020 23:30:47 -0700
Subject: [PATCH] allow borrowing from NewReference

implemented as an implicit conversion
---
 src/embed_tests/References.cs | 15 +++++++++++++++
 src/runtime/NewReference.cs   |  5 +++++
 2 files changed, 20 insertions(+)

diff --git a/src/embed_tests/References.cs b/src/embed_tests/References.cs
index 4c7124907..1d29e85c7 100644
--- a/src/embed_tests/References.cs
+++ b/src/embed_tests/References.cs
@@ -36,5 +36,20 @@ public void MoveToPyObject_SetsNull()
                 reference.Dispose();
             }
         }
+
+        [Test]
+        public void CanBorrowFromNewReference()
+        {
+            var dict = new PyDict();
+            NewReference reference = Runtime.PyDict_Items(dict.Handle);
+            try
+            {
+                PythonException.ThrowIfIsNotZero(Runtime.PyList_Reverse(reference));
+            }
+            finally
+            {
+                reference.Dispose();
+            }
+        }
     }
 }
diff --git a/src/runtime/NewReference.cs b/src/runtime/NewReference.cs
index 3ab4b6530..6e66232d0 100644
--- a/src/runtime/NewReference.cs
+++ b/src/runtime/NewReference.cs
@@ -11,6 +11,10 @@ ref struct NewReference
     {
         IntPtr pointer;
 
+        [Pure]
+        public static implicit operator BorrowedReference(in NewReference reference)
+            => new BorrowedReference(reference.pointer);
+
         /// <summary>
         /// Returns <see cref="PyObject"/> wrapper around this reference, which now owns
         /// the pointer. Sets the original reference to <c>null</c>, as it no longer owns it.
@@ -36,6 +40,7 @@ public void Dispose()
         /// <summary>
         /// Creates <see cref="NewReference"/> from a raw pointer
         /// </summary>
+        [Pure]
         public static NewReference DangerousFromPointer(IntPtr pointer)
             => new NewReference {pointer = pointer};