Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 053eee1

Browse files
authored
Merge pull request plotly#984 from plotly/branden-patch-2
update deploy and checking
2 parents d01be87 + 571dee9 commit 053eee1

File tree

4 files changed

+9
-26
lines changed

4 files changed

+9
-26
lines changed

Contributing.md

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -72,23 +72,9 @@ git add file-b
7272
git commit -m 'message about your changes'
7373
git push origin your_feature_branch
7474
```
75-
Visit the [documentation repo](https://github.com/plotly/documentation) and open a pull request against the `source-design-merge` branch. You can then tag @cldougl and @bcdunbar for a review.
75+
Visit the [documentation repo](https://github.com/plotly/documentation) and open a pull request against the `source-design-merge` branch. You can then tag **@cldougl** and **@bcdunbar** for a review.
7676

77-
## Deploying Changes
78-
After your PR has been approved and you have merged it into the `source-design-merge` branch you can deploy your changes! Our repo has become too big for github to process. Edit files on the `source-design-merge` branch instead of the `gh-pages` branch.
79-
80-
First checkout the `source-design-merge` branch (if you were still on your feature branch) and pull (you should see the changes from your latest merged pr):
81-
```
82-
git checkout source-design-merge
83-
git pull origin source-design-merge
84-
```
85-
86-
Deploy changes with:
87-
```
88-
documentation (source-design-merge) $ bundle exec rake deploy
89-
```
90-
91-
(from the `source-design-merge` branch in the root of the `documentation` repo)
77+
After your PR has been reviewed and approved, you can merge it into the `source-design-merge` branch! Your changes haven't been deployed yet so they won't be online. That said, be sure to check them after they have been deployed by either **@cldougl** or **@bcdunbar**.
9278

9379
## Search
9480

_posts/plotly_js/README.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -112,11 +112,9 @@ Our javascript tutorials are written in HTML files with embeded [codepen](http:/
112112
- Visit the [documentation repo](https://github.com/plotly/documentation) and open a pull request against the `source-design-merge` branch. You can then tag **@cldougl** and **@bcdunbar** for a review.
113113

114114
10. To proof your work follow these steps: https://github.com/plotly/documentation/blob/source/Contributing.md#rendering-the-pages-locally
115-
11. Deploy with `bundle exec rake deploy`
116115

117116
##### At https://plot.ly/javascript
118-
12. Check your Tutorial!!!! This is a <b>very important</b> step.
119-
<b>PLEASE</b> visit https://plot.ly/javascript/your-tutorial and make sure everything looks correct :)
117+
11. Your changes haven't been deployed yet so they won't be online. That said, <b>PLEASE</b> visit https://plot.ly/javascipt/your-tutorial and make sure everything looks correct once they have been deployed by either **@cldougl** or **@bcdunbar**.
120118

121119
- Some common problems that you should check for:
122120
- Make sure all plots/codepen embeds appear! (\*you may want to sign out of your Plotly/codepen account to ensure you didn't accidentally embed private plots)

_posts/python/README.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -138,11 +138,9 @@ Our python tutorials are written in [ipython notebooks](http://ipython.org/noteb
138138
- Visit the [documentation repo](https://github.com/plotly/documentation) and open a pull request against the `source-design-merge` branch. You can then tag **@cldougl** and **@bcdunbar** for a review.
139139
140140
10. To proof your work follow these steps: https://github.com/plotly/documentation/blob/source/Contributing.md#rendering-the-pages-locally
141-
11. Deploy with `bundle exec rake deploy`
142141
143142
##### At https://plot.ly/python
144-
12. Check your Tutorial!!!! This is a <b>very important</b> step.
145-
<b>PLEASE</b> visit https://plot.ly/python/your-tutorial and make sure everything looks correct :)
143+
11. Your changes haven't been deployed yet so they won't be online. That said, <b>PLEASE</b> visit https://plot.ly/python/your-tutorial and make sure everything looks correct once they have been deployed by either **@cldougl** or **@bcdunbar**.
146144
147145
- Some common problems that you should check for:
148146
- Make sure all plots appear! (*you may want to sign out of your Plotly account to ensure you didn't accidentally embed private plots)

_posts/r/README.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -126,11 +126,12 @@
126126
127127
5. To proof your work follow these steps: https://github.com/plotly/documentation/blob/source-design-merge/Contributing.md#rendering-the-pages-locally
128128
129-
6. Deploy with `bundle exec rake deploy`
130-
131129
##### At https://plot.ly/r
132-
7. Check your Tutorial!!!!
133-
<b>PLEASE</b> visit https://plot.ly/r/your-tutorial and make sure everything looks correct :)
130+
6. Your changes haven't been deployed yet so they won't be online. That said, <b>PLEASE</b> visit https://plot.ly/r/your-tutorial and make sure everything looks correct once they have been deployed by either **@cldougl** or **@bcdunbar**.
131+
132+
- Some common problems that you should check for:
133+
- Make sure all plots appear!
134+
- The thumbnail image appears on: https://plot.ly/r/
134135
135136
## Search
136137

0 commit comments

Comments
 (0)