Fix NPE in build trigger if the template returns a None (quay#395)

josephschorr · web-flow · commit 92b9b8c9ebd7 · 2020-05-27T16:27:25.000-04:00
diff --git a/buildtrigger/basehandler.py b/buildtrigger/basehandler.py
@@ -380,7 +380,7 @@ def _determine_tags(cls, config, metadata):
             for tag_template in tag_templates:
                 try:
                     result = apply_data_to_obj(tag_template, updated_metadata, missing="$MISSING$")
-                    if "$MISSING$" in result:
+                    if result and "$MISSING$" in result:
                         result = None
                 except JSONTemplateParseException:
                     logger.exception("Got except when parsing tag template `%s`", tag_template)
