Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[v2.7.1] Release Tracker #152627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
atalman opened this issue May 1, 2025 · 13 comments
Open

[v2.7.1] Release Tracker #152627

atalman opened this issue May 1, 2025 · 13 comments
Labels
oncall: releng In support of CI and Release Engineering release tracker Add this label to release tracker issues triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@atalman
Copy link
Contributor

atalman commented May 1, 2025

This issue is for tracking cherry-picks to the release branch. Following is release branch for the 2.7.1 release.

Our plan from this point is roughly the following:

  • Phase 1 (until 5/19): Cherry-pick post deadline (End of day 5PM PST)
  • Phase 2 (after 5/19): Perform extended integration/stability/performance testing based on Release Candidate builds.

Only issues that have ‘cherry-picks’ in this tracker will be considered for the release.

Cherry-Pick Criteria

Phase 1 (until 5/19):

Please note: No feature work allowed for cherry picks. The Releng team relies on the cherry pick process to manage risk to release quality, i.e. by porting a small set of commit from trunk that are "must-have" into the release branch, we limit the change to the minimal to address pressing issues. Thus, not everything a developer land into the trunk will make it into the release. So, please consider the criteria below and follow the cherry picking process. Only low-risk changes may be cherry-picked from master:

  1. Fixes to regressions against the most recent release (e.g. 2.7.0 for 2.7.1 release; see module: regression issue list)
  2. Low risk critical fixes for: silent correctness, backwards compatibility, crashes, deadlocks, (large) memory leaks
  3. Critical Fixes to new features being introduced in 2.7.0 release
  4. Documentation improvements
  5. Release branch specific changes (e.g. blocking ci fixes, change version identifiers)

Any other change requires special dispensation from the release managers (currently @atalman, @ZainRizvi , @seemethere @huydhn, @malfet). If this applies to your change please write "Special Dispensation" in the "Criteria Category:" template below and explain.

Phase 2 (after 5/19):

Note that changes here require us to rebuild a Release Candidate and restart extended testing (likely delaying the release). Therefore, the only accepted changes are Release-blocking critical fixes for: silent correctness, backwards compatibility, crashes, deadlocks, (large) memory leaks

Changes will likely require a discussion with the larger release team over VC or Slack.

Cherry-Pick Process

  1. Ensure your PR has landed in master. This does not apply for release-branch specific changes (see Phase 1 criteria).

  2. Create (but do not land) a PR against the release branch.

    # Find the hash of the commit you want to cherry pick
    # (for example, abcdef12345)
    git log
    
    git fetch origin release/2.7
    git checkout release/2.7
    git cherry-pick abcdef12345
    
    # Submit a PR based against 'release/2.7' either:
    # via the GitHub UI
    git push my-fork
    
    # via the GitHub CLI
    gh pr create --base release/2.7
  3. Make a request below with the following format:

Link to landed trunk PR (if applicable):
* 

Link to release branch PR:
* 

Criteria Category:
* 
  1. Someone from the release team will reply with approved / denied or ask for more information.
  2. If approved, someone from the release team will merge your PR once the tests pass. Do not land the release branch PR yourself.

NOTE: Our normal tools (ghstack / ghimport, etc.) do not work on the release branch.

See HUD 2.7

Versions

2.7.1

@atalman atalman added oncall: releng In support of CI and Release Engineering release tracker Add this label to release tracker issues triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels May 1, 2025
@atalman atalman pinned this issue May 1, 2025
@pytorchbot
Copy link
Collaborator

pytorchbot commented May 4, 2025

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:
Critical, fixes #152275


@atalman merged

@anijain2305
Copy link
Contributor

anijain2305 commented May 5, 2025

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:
Critical -


@atalman merged

@kwen2501
Copy link
Contributor

kwen2501 commented May 5, 2025

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:

  • Critical

@atalman wrote: Hi @kwen2501 could you please provide more details on why this is critical ? This issue existed in torch 2.6.0 as per: #149119. It does not fit cherry-picking criteria
@malfet : this sounds like an important issue, but I'm a bit concerned by the lack of test (or manual test plan)

@pytorchbot
Copy link
Collaborator

pytorchbot commented May 6, 2025

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:
Regression -


@malfet: merged

@malfet
Copy link
Contributor

malfet commented May 7, 2025

Link to landed trunk PR:

Link to release branch PR:

Criteria Category: CI Fixes (GH stopped providing Ubuntu-20 on Apr 1st 2025)


@malfet merged

@atalman
Copy link
Contributor Author

atalman commented May 7, 2025

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:

  • Release Wheels Dependencies - Poetry Related issue. TODO we would need to extend injection script for pypi with these dependencies

@atalman merged

@pytorchbot
Copy link
Collaborator

pytorchbot commented May 7, 2025

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:
Critical


@atalman merged

@pytorchbot
Copy link
Collaborator

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:
Critical -

@pytorchbot
Copy link
Collaborator

pytorchbot commented May 7, 2025

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:
Critical


@atalman merged
@malfet : it's OK to merge this change, but actually it is not needed, as fmsub is not used in any of the ops
@atalman : this was included in milestone 2.7.1, with reference issue: #149292

@drisspg
Copy link
Contributor

drisspg commented May 7, 2025

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:

  • crashes

@malfet
Copy link
Contributor

malfet commented May 7, 2025

Link to landed trunk PR:

Link to release branch PR:

Criteria Category:

  • Fixes silent correctness regression introduced in previous minor release

@pytorchbot
Copy link
Collaborator

pytorchbot commented May 8, 2025

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:
Critical Fixes to new features being introduced in 2.7.0 release

@StrongerXi
Copy link
Contributor

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:

  • Critical -- avoids extremely spammy log for torch.compile users that couldn't be turned off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oncall: releng In support of CI and Release Engineering release tracker Add this label to release tracker issues triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
Status: No status
Development

No branches or pull requests

7 participants