We cut a release branch for the 1.13.1 release.
Our plan from this point from this point is roughly:
- Phase 1 (until 12/8): Release Candidate 1
- Phase 2 (until 12/15): Tentative General Availability
This issue is for tracking cherry-picks to the release branch.
Cherry-Pick Criteria
Phase 1 (until 12/8/2022):
Only low-risk changes may be cherry-picked from master:
- Fixes to regressions against previous major version (e.g. regressions introduced in 1.13.0 from 1.12.0 are pickable for 1.13.1)
- Critical fixes for: silent correctness, backwards compatibility, crashes, deadlocks, (large) memory leaks
- Fixes to new features being introduced in this release
- Documentation improvements
- Release branch specific changes (e.g. blocking ci fixes, change version identifiers)
Any other change requires special dispensation from the release managers (currently @malfet, @atalman, @weiwangmeta , @izaitsevfb). If this applies to your change please write "Special Dispensation" in the "Criteria Category:" template below and explain.
Phase 2 (after 12/15/2022):
Note that changes here require us to rebuild a Release Candidate and restart extended testing (likely delaying the release). Therefore, the only accepted changes are Release-blocking critical fixes for: silent correctness, backwards compatibility, crashes, deadlocks, (large) memory leaks
Changes will likely require a discussion with the larger release team over VC or Slack.
Cherry-Pick Process
-
Ensure your PR has landed in master. This does not apply for release-branch specific changes (see Phase 1 criteria).
-
Create (but do not land) a PR against the release branch.
Details
# Find the hash of the commit you want to cherry pick
# (for example, abcdef12345)
git log
git fetch origin release/1.13
git checkout release/1.13
git cherry-pick abcdef12345
# Submit a PR based against 'release/1.10' either:
# via the GitHub UI
git push my-fork
# via the GitHub CLI
gh pr create --base release/1.13
-
Make a request below with the following format:
Link to landed master PR (if applicable):
*
Link to release branch PR:
*
Criteria Category:
*
- Someone from the release team will reply with approved / denied or ask for more information.
- If approved, someone from the release team will merge your PR once the tests pass. Do not land the release branch PR yourself.
NOTE: Our normal tools (ghstack / ghimport, etc.) do not work on the release branch.
See HUD 1.13
We cut a release branch for the 1.13.1 release.
Our plan from this point from this point is roughly:
This issue is for tracking cherry-picks to the release branch.
Cherry-Pick Criteria
Phase 1 (until 12/8/2022):
Only low-risk changes may be cherry-picked from master:
Any other change requires special dispensation from the release managers (currently @malfet, @atalman, @weiwangmeta , @izaitsevfb). If this applies to your change please write "Special Dispensation" in the "Criteria Category:" template below and explain.
Phase 2 (after 12/15/2022):
Note that changes here require us to rebuild a Release Candidate and restart extended testing (likely delaying the release). Therefore, the only accepted changes are Release-blocking critical fixes for: silent correctness, backwards compatibility, crashes, deadlocks, (large) memory leaks
Changes will likely require a discussion with the larger release team over VC or Slack.
Cherry-Pick Process
Ensure your PR has landed in master. This does not apply for release-branch specific changes (see Phase 1 criteria).
Create (but do not land) a PR against the release branch.
Details
Make a request below with the following format:
NOTE: Our normal tools (ghstack / ghimport, etc.) do not work on the release branch.
See HUD 1.13