[CPU] fix _weight_int8pack_mm with large output shape #158341
+44
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158341
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit eeb0d08 with merge base a5e6881 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
mingfeima
requested changes
Jul 16, 2025
mingfeima
approved these changes
Jul 16, 2025
|
Hi @lezcano @nikitaved @IvanYashchuk Could you please review this PR since you are code owners? Thanks |
|
@pytorchbot merge |
Merge failedReason: Approvers from one of the following sets are needed:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
_weight_int8pack_mmon CPU may cause segmentation fault if output shape is large (i.e., M * N is large). It's because the kernel compute output buffer address byauto* C_ptr = C_data + mb_start * N + nb_start;where both
mb_startandNareintand when they are large their product may overflow.The solution is simple: declare these variables as
int64_tso that the product won't overflow.Test plan
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @jerryzh168