-
-
Notifications
You must be signed in to change notification settings - Fork 18
Description
Hey, thanks for forking my action and making some changes! It looks like you addressed some bugs? Was there a reason you went with a fork instead of proposing PRs with fixes? I'd have happily accepted them. I could understand if you planned to change the approach, where you may want your own fork. If yours works well I may just deprecate mine and switch to your fork.
edit: Testing your fork since I only use this action in one place. Looks like you may have fixed an issue with the timeout not being correctly respected.
edit 2: Yep, this is great, thanks for finding/fixing these issues. π I've tried to document the changes below for reference. I will go ahead and add a notice to my README to redirect people here. Since I have some existing content/videos that reference my fork, I think I can archive it and it'll still work? I'll figure it out.
Changes
- Fix issue with
max_timeout
not working correctly - Change
site_name
tosite_id
to have a more stable reference ID to lookup - Better waiting semantics for the deployment status
- For full history see: https://github.com/probablyup/wait-for-netlify-action/releases